I finally got this reproducing locally, at least.

Gah.

I "fixed" this by deleting the data more aggressively and reloading the import. I couldn't reproduce this locally so I think it was a transient issue with an older import bug.

It seems that we're somehow importing events so they end up as their own parents.

That changed the stack trace but didn't fix the issue so I probably need to not cheat.

I can't reproduce this locally and I'm not really sure what's up (bad/weird import, maybe? But no issues importing the same source locally), so I'm just going to cheat my way through it at least for the moment.

Here's the trace:

These are very much proof-of-concept for now, but should technically work after D16784. Expected behavior now:

It may surprise us how much people use it.

I guess we're just accepting Calendar bugs in general now since I don't have a ton of known broken stuff left on my radar. I was aware of this one; D16777 should fix it.

I got 12 quest points. Level up!

Please be sure to update Phabricator before filing a bug report.

@rabahmeradi So it was, shortly afer reporting! Thanks.

In T11801#198622, @adam93 wrote:

Mentioned in chat but just to keep it logged. Importing an ics file with the following RRULE (RRULE:FREQ=WEEKLY;BYDAY=TH;INTERVAL=2) works as expected opening in Microsoft Outlook, but gives the following error in Phabricator upon import "RRULE INTERVAL "2" is invalid: interval must be an integer."

As @epriestley said in the general chat "We're missing an (int) cast in PhutilRecurrenceRule::newFromRRULE() on INTERVAL and probably COUNT".

Mentioned in chat but just to keep it logged. Importing an ics file with the following RRULE (RRULE:FREQ=WEEKLY;BYDAY=TH;INTERVAL=2) works as expected opening in Microsoft Outlook, but gives the following error in Phabricator upon import "RRULE INTERVAL "2" is invalid: interval must be an integer."

Duplicate thing filed in T11800.

I'm going to file the duplicate import thing as a separate task since it probably won't come up for a while and close this out.

(Google API integration is covered by T2334 -- you can already interact with Google Calendar via ICS files, but that will add support for using the API instead.)

The Gmail/ICS integration seems to actually work OK in practice, here's an event from this install working (modulo some stuff like us not exporting a host/organizer yet):

OK I imported some real great events:

I'm just going to "fix" this by just preventing you from hiding/locking/defaulting these fields, since it doesn't seem useful to create a "New Event on January 3, 2013" sort of form anyway.

D16752 was approximately the same thing but I think this is a little complicated -- both in general, and for recurring events. I'm also not really sure this should use the trigger system at all.