Page MenuHomePhabricator
Feed Advanced Search

Apr 9 2015

epriestley added a parent task for T5031: Draft Comment Persists After Submission: T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.
Apr 9 2015, 3:26 PM · Restricted Project, Support Impact, Mobile

Apr 6 2015

btrahan closed T7762: Display Preferences text box is too wide on mobile as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 5:10 PM · User Preferences, Mobile
btrahan added a revision to T7762: Display Preferences text box is too wide on mobile: Restricted Differential Revision.
Apr 6 2015, 5:06 PM · User Preferences, Mobile

Apr 5 2015

csilvers added a comment to T7760: cannot add users to projects on the mobile site.

My apologies! I looked at that menu and somehow totally missed it.

Apr 5 2015, 4:05 AM · Projects, Mobile
joshuaspence added a comment to T7762: Display Preferences text box is too wide on mobile.

The monospaced text also overflows:

Apr 5 2015, 2:26 AM · User Preferences, Mobile
joshuaspence added a comment to T7763: Hard to add files on mobile.

I thought that this might be closed as a duplicate... Although I think that adding "File" to the quick create menu might be a quick win here... Is there any specific objection to this?

Apr 5 2015, 2:23 AM · Mobile, Files
chad merged task T7763: Hard to add files on mobile into T5187: Make "Upload File" dialog have a vanilla file upload control.
Apr 5 2015, 1:55 AM · Mobile, Files
joshuaspence created T7763: Hard to add files on mobile.
Apr 5 2015, 1:53 AM · Mobile, Files
joshuaspence created T7762: Display Preferences text box is too wide on mobile.
Apr 5 2015, 1:50 AM · User Preferences, Mobile

Apr 4 2015

chad closed T7760: cannot add users to projects on the mobile site as Invalid.

Click the Mobile Menu, then Members.

Apr 4 2015, 8:28 PM · Projects, Mobile
csilvers created T7760: cannot add users to projects on the mobile site.
Apr 4 2015, 8:07 PM · Projects, Mobile

Mar 25 2015

epriestley updated subscribers of T5031: Draft Comment Persists After Submission.
Mar 25 2015, 10:44 AM · Restricted Project, Support Impact, Mobile

Mar 22 2015

epriestley closed T7474: "Request Desktop Site" doesnt work as Wontfix.

I don't think there's anything reasonable we can do here.

Mar 22 2015, 12:17 PM · Mobile

Mar 19 2015

Mnkras added a comment to T7290: Mobile CSS doesn't always load properly on the home page.

Ran into it again, (on this install)

Mar 19 2015, 7:46 PM · Javelin, Mobile
chad moved T5390: Improve mobile experience in Conpherence from v3 to Future on the Conpherence board.
Mar 19 2015, 3:12 PM · Conpherence, Mobile

Mar 13 2015

chad closed T7300: XHProf application is not optimized for mobile as Resolved.

Should be resolved, probably.

Mar 13 2015, 6:41 PM · Mobile, XHProf

Mar 10 2015

chad closed T7032: Scrolling of revisions is broken on Chrome 41 all as Resolved.

Presume fixed since you don't to scroll left/right anymore.

Mar 10 2015, 10:44 PM · Google Chrome, Differential, Mobile

Mar 6 2015

hach-que added a comment to T7474: "Request Desktop Site" doesnt work.

The feature basically changes the User Agent to desktop Chrome as far as I know, and nothing more. That's why Phabricator doesn't appear any different, because the CSS is already optimized for mobile based on actual screen size (and not redirecting based on user agent).

Mar 6 2015, 7:19 AM · Mobile
chad added a comment to T7474: "Request Desktop Site" doesnt work.

I think their premise is sound in general, since sites sometimes display full alternate sites (I hate when my wife links me mobile URLs and I'm on a desktop). But we serve the full site with just different CSS, so nothing should be missing.

Mar 6 2015, 7:17 AM · Mobile
hach-que added a comment to T7474: "Request Desktop Site" doesnt work.

The only time I ever tried to use this was when the project sidebar wasn't available / usable on mobile and I had no way of creating a workboard.

Mar 6 2015, 7:17 AM · Mobile
joshuaspence added a comment to T7474: "Request Desktop Site" doesnt work.

I was just curious as to what it would do... I'm happy for this to be closed as "Wontfix".

Mar 6 2015, 7:15 AM · Mobile
chad added a comment to T7474: "Request Desktop Site" doesnt work.

Are you using this or just testing? In practice, I don't want to support this.

Mar 6 2015, 7:11 AM · Mobile
joshuaspence created T7474: "Request Desktop Site" doesnt work.
Mar 6 2015, 7:10 AM · Mobile

Mar 5 2015

avivey added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

Just tested it again with a touchpad (laptop), and it still works.

Mar 5 2015, 5:50 PM · Google Chrome, Differential, Mobile
chad added a revision to T7300: XHProf application is not optimized for mobile: Restricted Differential Revision.
Mar 5 2015, 4:47 PM · Mobile, XHProf
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

Definitely desirable, although some of them (releeph, oauth server, arcanist project edit) might be tricky to test.

Mar 5 2015, 4:20 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

There is a manageable number of buildStandardPage callsites, might be easy to remove if there is only 1-2 missing features.

Mar 5 2015, 4:12 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

Typically I'd just switch this over to buildApplicationPage and call it a day, but I don't think that works with frame.

Mar 5 2015, 4:11 PM · Mobile, XHProf
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

I think we can put the frame logic in buildApplicationPage(), and then switch to it. I can tackle that if you aren't sure how to not break stuff.

Mar 5 2015, 4:10 PM · Mobile, XHProf
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

buildApplicationPage() calls setDeviceReady(true) on the $page, buildStandardPage() does not.

Mar 5 2015, 4:09 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

I'm not sure how best to proceed here. What's the difference with buildApplicationPage and buildStandardPage when it comes to device?

Mar 5 2015, 4:06 PM · Mobile, XHProf
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

Removing $is_framed will break the DarkConsole "XHProf" tab, which loads the profile in an <iframe />.

Mar 5 2015, 3:21 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

hmmm maybe this is buildStandardPage thing.

Mar 5 2015, 3:20 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

Oh, on an actual mobile device. We should remove that JS check now, I think it's safe globally.

Mar 5 2015, 2:59 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

I assume you mean the table? That is our mobile display for tables (scrollable).

Mar 5 2015, 2:28 PM · Mobile, XHProf
chad added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

Are you on a laptop? Seems touch specific.

Mar 5 2015, 2:24 PM · Google Chrome, Differential, Mobile
joshuaspence reopened T7300: XHProf application is not optimized for mobile as "Open".

Not quite, see https://secure.phabricator.com/xhprof/profile/PHID-FILE-i37p3oetbxkqjt2fs35h/.

Mar 5 2015, 8:15 AM · Mobile, XHProf
avivey added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

works for me on Windows/Chrome 41. Just to make it more annoying, I guess.

Mar 5 2015, 6:06 AM · Google Chrome, Differential, Mobile
chad added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

Well this now repros in plain Mac/Chrome v41. Help me 1-up diff view, you're my only hope!

Mar 5 2015, 4:20 AM · Google Chrome, Differential, Mobile
chad renamed T7032: Scrolling of revisions is broken on Chrome 41 all from Scrolling of revisions is broken on Chrome 40 on Android to Scrolling of revisions is broken on Chrome 41 all.
Mar 5 2015, 4:19 AM · Google Chrome, Differential, Mobile

Mar 4 2015

chad moved T7032: Scrolling of revisions is broken on Chrome 41 all from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:09 PM · Google Chrome, Differential, Mobile

Mar 1 2015

chad moved T5390: Improve mobile experience in Conpherence from Backlog to v3 on the Conpherence board.
Mar 1 2015, 12:09 AM · Conpherence, Mobile

Feb 26 2015

chad added a comment to T7300: XHProf application is not optimized for mobile.

Seems working fine now on mobile.

Feb 26 2015, 3:33 AM · Mobile, XHProf
chad closed T7300: XHProf application is not optimized for mobile as Resolved.
Feb 26 2015, 3:33 AM · Mobile, XHProf

Feb 20 2015

• chasemp added a comment to T7290: Mobile CSS doesn't always load properly on the home page.

I have a Droid MAXX and see this sort of thing sometimes as well. It usually clears up on a reload of the page.

Feb 20 2015, 4:27 PM · Javelin, Mobile

Feb 19 2015

hach-que added a comment to T7290: Mobile CSS doesn't always load properly on the home page.

I see this on secure.phabricator.com and local installs.

Feb 19 2015, 12:16 AM · Javelin, Mobile

Feb 18 2015

chad added a comment to T7290: Mobile CSS doesn't always load properly on the home page.

It would also be useful to know if this is a secure.phabricator.com issue or you see it on your local installs as well.

Feb 18 2015, 11:08 PM · Javelin, Mobile
chad added a comment to T7290: Mobile CSS doesn't always load properly on the home page.

Next time people see it, it would be nice to confirm suspicions that JavaScript isn't running (toggle a menu or something?)

Feb 18 2015, 10:51 PM · Javelin, Mobile
chad added projects to T7290: Mobile CSS doesn't always load properly on the home page: Mobile, Javelin.

It seems to happens if JavaScript doesn't download / execute, which breaks lots of things (besides layout). Unclear why though or how to reproduce with consistency (perhaps even a CDN issue?). I've only seen it maybe 1/1000 page loads.

Feb 18 2015, 4:43 PM · Javelin, Mobile
epriestley added a comment to T7300: XHProf application is not optimized for mobile.

I almost merged them when they popped up. :P

Feb 18 2015, 3:05 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

OIC, I am confusing XPHAST and XHPROF tasks, I'm a bit jetlagged it seems. Didn't notice two different tasks here.

Feb 18 2015, 3:04 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

Haha, well you know me and killing apps. Always a fan. :-)

Feb 18 2015, 2:53 PM · Mobile, XHProf
epriestley triaged T7300: XHProf application is not optimized for mobile as Wishlist priority.

This stretches the bounds of imagination, but I can come up with a use: although we do only a tiny amount of this today, a possible use case is that we may take a different server-side rendering pathway for mobile agents than we do for desktop agents in the future. This does technically happen today, but the amount of code involved is tiny, and is unlikely to ever affect a profile.

Feb 18 2015, 2:50 PM · Mobile, XHProf
chad added a comment to T7300: XHProf application is not optimized for mobile.

@joshuaspence my assumption is exactly 0 people use this tool on mobile, And maybe 5 use it on desktop.

Feb 18 2015, 2:33 PM · Mobile, XHProf
joshuaspence added a comment to T7300: XHProf application is not optimized for mobile.

Definitely low priority, but why not?

Feb 18 2015, 7:39 AM · Mobile, XHProf
epriestley added a comment to T7301: XHPAST application is not optimized for mobile.

Yes. My clever plan is to wait for mobile devices to have an effective resolution of 3600x8200 and MindMouse technology.

Feb 18 2015, 5:22 AM · XHPAST, Mobile
chad added a comment to T7301: XHPAST application is not optimized for mobile.

after the IPO

Feb 18 2015, 5:21 AM · XHPAST, Mobile
epriestley triaged T7301: XHPAST application is not optimized for mobile as Wishlist priority.
Feb 18 2015, 5:17 AM · XHPAST, Mobile
epriestley claimed T7301: XHPAST application is not optimized for mobile.

I'll show you! I'll make this the greatest mobile app the world has ever seen!

Feb 18 2015, 5:17 AM · XHPAST, Mobile
Mnkras added a comment to T7301: XHPAST application is not optimized for mobile.

Yea, there are just certain things you can't make mobile friendly, I think this may be one of them.

Feb 18 2015, 5:07 AM · XHPAST, Mobile
chad removed a project from T7301: XHPAST application is not optimized for mobile: Design.
Feb 18 2015, 4:39 AM · XHPAST, Mobile
chad added a comment to T7301: XHPAST application is not optimized for mobile.

This is "working as intended" on mobile. We should maybe mark XHPAST as developer/prototype or something.

Feb 18 2015, 4:38 AM · XHPAST, Mobile
chad added a comment to T7300: XHProf application is not optimized for mobile.

I can't imagine someone using this on mobile, is there a need for it o can't think of?

Feb 18 2015, 2:00 AM · Mobile, XHProf
chad removed a project from T7300: XHProf application is not optimized for mobile: Design.
Feb 18 2015, 2:00 AM · Mobile, XHProf

Feb 17 2015

joshuaspence updated the task description for T7301: XHPAST application is not optimized for mobile.
Feb 17 2015, 8:56 PM · XHPAST, Mobile
joshuaspence created T7301: XHPAST application is not optimized for mobile.
Feb 17 2015, 8:55 PM · XHPAST, Mobile
joshuaspence created T7300: XHProf application is not optimized for mobile.
Feb 17 2015, 8:50 PM · Mobile, XHProf

Feb 15 2015

chad merged task T7274: Support uploading on a mobile into T5187: Make "Upload File" dialog have a vanilla file upload control.
Feb 15 2015, 12:39 PM · Mobile, Files
chad lowered the priority of T7274: Support uploading on a mobile from Unbreak Now! to Needs Triage.
Feb 15 2015, 12:38 PM · Mobile, Files
• paladox triaged T7274: Support uploading on a mobile as Unbreak Now! priority.
Feb 15 2015, 11:36 AM · Mobile, Files
• paladox added a comment to T7274: Support uploading on a mobile.

I am not sure which project this goes into.

Feb 15 2015, 11:36 AM · Mobile, Files
• paladox created T7274: Support uploading on a mobile.
Feb 15 2015, 11:35 AM · Mobile, Files

Jan 27 2015

chad added a project to T7032: Scrolling of revisions is broken on Chrome 41 all: Android.
Jan 27 2015, 2:49 PM · Google Chrome, Differential, Mobile
joshuaspence updated subscribers of T7029: Tokenizers lose state changes after navigation actions.
Jan 27 2015, 7:04 AM · Mobile, Maniphest

Jan 25 2015

chad added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

Loaded up my Nexus for 4 for testing, Android 4.4.4 with Chrome 35, not reproducible. Updated to latest (40) and it reproduces.

Jan 25 2015, 5:56 PM · Google Chrome, Differential, Mobile
chad renamed T7032: Scrolling of revisions is broken on Chrome 41 all from Scrolling of revisions is broken on Chrome on Android (?), probably as expected (?) to Scrolling of revisions is broken on Chrome 40 on Android.
Jan 25 2015, 5:55 PM · Google Chrome, Differential, Mobile
epriestley added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

I can't reproduce this on iOS.

Jan 25 2015, 1:45 PM · Google Chrome, Differential, Mobile
epriestley renamed T7032: Scrolling of revisions is broken on Chrome 41 all from Scrolling of revisions is broken on mobile, probably as expected to Scrolling of revisions is broken on Chrome on Android (?), probably as expected (?).
Jan 25 2015, 1:45 PM · Google Chrome, Differential, Mobile
epriestley renamed T7032: Scrolling of revisions is broken on Chrome 41 all from Scroll is completely broken to Scrolling of revisions is broken on mobile, probably as expected.
Jan 25 2015, 1:42 PM · Google Chrome, Differential, Mobile
joshuaspence updated the task description for T7032: Scrolling of revisions is broken on Chrome 41 all.
Jan 25 2015, 7:53 AM · Google Chrome, Differential, Mobile
chad added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

I don't think this is new, it's worked like this for some time, not sure if its "more sensitive" with the changes or not, but that area has always been sub-optimal until we get 1-up diffs.

Jan 25 2015, 6:01 AM · Google Chrome, Differential, Mobile
chad added a comment to T7032: Scrolling of revisions is broken on Chrome 41 all.

It looks like you started scrolling left/right in the diff area. If your finger is on that area, it's more sensitive to where your scrolling since it can be left/right/up/down.

Jan 25 2015, 6:00 AM · Google Chrome, Differential, Mobile
joshuaspence created T7032: Scrolling of revisions is broken on Chrome 41 all.
Jan 25 2015, 5:55 AM · Google Chrome, Differential, Mobile
chad added a comment to T7029: Tokenizers lose state changes after navigation actions.

Hah, well at least Chrome on iOS doesn't seem to have this behavior. Strange that iOS is better than Android though for Chrome. Is it a current version?

Jan 25 2015, 4:02 AM · Mobile, Maniphest
joshuaspence added a comment to T7029: Tokenizers lose state changes after navigation actions.

Serializing into a hidden field sounds like the correct approach to me.

Jan 25 2015, 12:11 AM · Mobile, Maniphest
epriestley added a comment to T7029: Tokenizers lose state changes after navigation actions.

Native fields (text, textarea) work fine; tokenizers exhibit this behavior because (some hand-waving here) we aren't writing their values to a real input, sort of, probably. Blah blah bfcache browsers etc etc.

Jan 25 2015, 12:04 AM · Mobile, Maniphest
joshuaspence added a comment to T7029: Tokenizers lose state changes after navigation actions.

You can reproduce this in a normal web browser (at least, in Safari):

  • Click "Edit Task" on any task.
  • Add a project to the "Projects" field.
  • Type some text in the "Description" field.
  • Click a link on the page, like the Phabricator logo.
  • Press the browser back button.

The description change persists, but the field change does not.

This is probably fixable, but also probably involves some stupid garbage nonsense where we serialize tokens into a hidden field value.

Jan 25 2015, 12:01 AM · Mobile, Maniphest

Jan 24 2015

joshuaspence added a comment to T7029: Tokenizers lose state changes after navigation actions.

Actually, it seems that the subscribers field doesn't persist either (I originally thought that it did, but it seems that only the default subscriber of myself persists). So yeah, this may not be fixable.

Jan 24 2015, 11:59 PM · Mobile, Maniphest
epriestley added a comment to T7029: Tokenizers lose state changes after navigation actions.

You can reproduce this in a normal web browser (at least, in Safari):

Jan 24 2015, 11:59 PM · Mobile, Maniphest
joshuaspence added a comment to T7029: Tokenizers lose state changes after navigation actions.

Seeing as the other fields persist, I suspect that it should be fixable.

Jan 24 2015, 11:55 PM · Mobile, Maniphest
chad added a comment to T7029: Tokenizers lose state changes after navigation actions.

Do you feel this is fixable by Phabricator?

Jan 24 2015, 11:54 PM · Mobile, Maniphest
joshuaspence created T7029: Tokenizers lose state changes after navigation actions.
Jan 24 2015, 11:52 PM · Mobile, Maniphest

Jan 17 2015

chad updated the task description for T5752: Navigation menus should work correctly on mobile by default.
Jan 17 2015, 11:04 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
chad renamed T5752: Navigation menus should work correctly on mobile by default from Navigation menus and action items should work correctly on mobile by default to Navigation menus should work correctly on mobile by default.
Jan 17 2015, 11:04 PM · ApplicationEditor, Infrastructure, PHUI, Mobile

Jan 14 2015

chad closed T6964: Title is cut off by action menu as Resolved by committing Restricted Diffusion Commit.
Jan 14 2015, 12:11 AM · PHUI, Mobile
chad added a revision to T6964: Title is cut off by action menu: Restricted Differential Revision.
Jan 14 2015, 12:07 AM · PHUI, Mobile

Jan 13 2015

chad edited projects for T6964: Title is cut off by action menu, added: PHUI; removed Design.
Jan 13 2015, 9:02 PM · PHUI, Mobile
joshuaspence added a project to T6964: Title is cut off by action menu: Mobile.
Jan 13 2015, 8:34 PM · PHUI, Mobile

Jan 12 2015

chad added a revision to T5752: Navigation menus should work correctly on mobile by default: Restricted Differential Revision.
Jan 12 2015, 4:19 AM · ApplicationEditor, Infrastructure, PHUI, Mobile
chad added a comment to T5752: Navigation menus should work correctly on mobile by default.

Oh silly, I see we're passing PropertyList into ObjectBoxView anyways. Alright, should be able to figure this out after kiddo bath time.

Jan 12 2015, 2:25 AM · ApplicationEditor, Infrastructure, PHUI, Mobile