Closed by commit rP26f283fe21a5.

I don't think denying access based on MFA or requiring it over Conduit would be very useful because we currently enforce MFA and it would remove the primary use; which is build agents retrieving credentials.

Yeah, I think the HarbormasterBuildTargetQuery should maybe attach a null value in this case when the step doesn't exist? Then any logic using the step can just skip over it.

Closed by commit rPddacb03be660.

The primary reason for UI focus was that I imagined people using this like Herald. Instead of setting up "build on commit" rules in Harbormaster, those are configured in Herald.

From IRC (primarily notes for myself):

It's on the same domain as JIRA. I'm reasonably sure they use Javascript to change the favicon and thus it doesn't impact favicon.ico at all.

Yes

Closed by commit rPbc116d7e02b4.

Also, given what I've outlined in the above comment, I don't think we need merging of execution threads.

"Run another build plan" is more around solving "I want to restart the build, but I don't want to repeat things that have already been successful". I think it's solves this pretty well (where the relevant artifacts are stored in a separate system and the buildable's identifier is used to look them up).

Yeah sorry, I was planning on getting time to look at this, but then stuff happened and I didn't.

(This is primarily just an annoyance for now since I just remove the content in the "requires" array and everything works, but I have accidentally committed code with the requires present and broken things in the past)

Closed by commit rP46b4fa85d097.

If SSH is enabled, machines can make service calls over SSH directly (ssh ... conduit method.name). If SSH is not enabled, we can sign HTTP requests using keys to achieve the same effect.

In T4209#21, @epriestley wrote:

That's potentially useful, yes. I think a rough sketch of the plan of attack here is:

Finish T2783: Most of the remaining work on T2783 can happen at any time: convert remaining calls in Diffusion and the daemons (other than the PullLocal daemon) into Conduit calls. There should be only a handful of these left.

Build a Service Directory: This is a new application which lists all the hosts which provide services. For example: all of the machines running with some Phabricator responsibilities, all the MySQL databases, etc. It might make sense to generalize this. For example, maybe it would be reasonable to list Jenkins instances as services here for Harbormaster to use?

I'm presuming that in a high availability configuration, there'd be machines running Phabricator with a web interface, but are just responsible for running daemons or repository hosting / replication?

I didn't really want to nag Evan, given that we both know that some of these are low priority on upstream's roadmap. At the same time, I didn't want these reviews to be lost under the bajillion diffs Evan must get on a regular basis.

Has this been happening only recently? Since rP2101c3b?

I don't think submodules would be the best option here. Git submodules work when you have a strict hierarchy, but I can see libphutil modules being more like a graph.

I think that Aphront should probably be in it's own module, rather than being added to libphutil. Celerity would also be in that module.

I upgraded to HEAD and the issue went away.

This is also killing the Git commit change worker:

I think this is best solved with D9807, where you move the parts of the build you want to be able to restart into a separate build plan, and then you invoke that build plan from the parent. This allows each build plan to encapsulate it's own resources and artifacts (like Allocate Host) and we don't have to worry about any resource holding or nonsense like that.

The question is how to structure more than one branch. Should it be encoded in JSON (in which case we make it hard for shell scripts to parse) or do we separate it with a character (which makes it non-standard and require custom parsing)? We can't use new lines (the default shell scripting separator), because the variable needs to be able to be passed through on both UNIX and Windows command lines.