Page MenuHomePhabricator
Create Task
Maniphest T4884

At some point, review hach-que's diffs
Closed, InvalidPublic
Actions

Description

Although not urgent, I am aware that some of these diffs are approaching >1 month old.

Some of these will likely be "Request Changes" and we probably talked about them on IRC, but I've got no idea where they're at or what changes I need to make in some cases.

Revisions and Commits

rPHU libphutil
AbandonedD9115 Fix the Futures iterator so that it always tasks up to the limit
rARC Arcanist
ClosedD8729 Handles an issue in windows with large code bases not squash merging correctly.
rP Phabricator
AbandonedD9130 Publish branch lint information into Fact
AbandonedD9113 Implement a very rough version of saving lint from Harbormaster
AbandonedD9001 Fix a crash when uploading a ZIP to Phragment
ClosedD8784 Support custom actions in Herald
AbandonedD8797 Allow Herald rules to check unit / lint status and LOC
AbandonedD8672 Create file controller in Phragment
AbandonedD8671 Create preceding paths for fragments
AbandonedD8669 Add phragment.querysnapshots method
AbandonedD8660 Support querying a specific snapshot on phragment.queryfragments
AbandonedD8655 Allow Phabricator to redirect to Amazon S3 for file downloads
AbandonedD8641 Allow users to choose what types of buildables they want to publish fragments for

Event Timeline

hach-que created this task.Apr 23 2014, 10:29 PM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Phabricator.
hach-que added a subscriber: hach-que.
hach-que edited this Maniphest Task.Apr 23 2014, 10:31 PM
hach-que assigned this task to epriestley.Apr 23 2014, 10:32 PM
hach-que updated the task description. (Show Details)
hach-que edited this Maniphest Task.Apr 23 2014, 10:34 PM
hach-que edited this Maniphest Task.May 7 2014, 6:15 AM
hach-que edited this Maniphest Task.
hach-que edited this Maniphest Task.May 15 2014, 12:07 AM
hach-que edited this Maniphest Task.May 15 2014, 12:11 AM
hach-que edited this Maniphest Task.
hach-que edited this Maniphest Task.May 16 2014, 3:05 AM
mikn added a subscriber: mikn.Jun 25 2014, 10:57 AM
btrahan closed this task as Invalid.Jul 30 2014, 10:06 PM
btrahan added a subscriber: btrahan.

I'm doing some task cleanup at the moment. Mind just nagging Evan via Differential and if you have to come over the top use IRC? :D

hach-que added a comment.EditedJul 31 2014, 11:33 AM

I didn't really want to nag Evan, given that we both know that some of these are low priority on upstream's roadmap. At the same time, I didn't want these reviews to be lost under the bajillion diffs Evan must get on a regular basis.

I do think that the Phragment stuff is probably getting to a point where it needs to be updated and then reviewed with a short turn around, because some of the recent major refactoring has broken / made them out of date with the new conventions.

Phabricator · Built by Phacility