Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 4:39 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()"

Summary

Ref T11968. This future-level parameter has no nontrivial callers and makes the "fate of FutureGraph" changes more difficult.

Callers that are genuinely interested in this behavior can wrap the Future in a FutureIterator and use "setUpdateInterval()" to get the same behavior.

Test Plan

Grepped for "resolve()" and "resolvex()", updated callers.

Diff Detail

Repository

rARC Arcanist

Branch

fx1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/future/Future.php:35	XHP62	Class Name Literal

Unit

Tests Passed

Build Status

Buildable 23921
Build 32917: Run Core Tests
Build 32916: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 26 2020, 4:39 PM

Harbormaster completed remote builds in B23921: Diff 50100.Feb 26 2020, 4:40 PM

epriestley requested review of this revision.Feb 26 2020, 4:40 PM

epriestley added a child revision: D21032: Remove the "preg_quote()" lint rule and update the "__CLASS__" lint rule.Feb 26 2020, 4:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2020, 5:14 PM

Closed by commit rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()".

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

29 lines

FutureProxy.php

4 lines

exec/

ExecFuture.php

18 lines

__tests__/

ExecFutureTestCase.php

9 lines

workflow/

ArcanistWorkflow.php

4 lines

Diff 50100

View Options

src/future/Future.php

View Options

src/future/FutureProxy.php

View Options

src/future/exec/ExecFuture.php

View Options

src/future/exec/tests/ExecFutureTestCase.php

View Options

src/workflow/ArcanistWorkflow.php

Remove the "timeout" parameter from "Future->resolve()"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50100

src/future/Future.php

src/future/FutureProxy.php

src/future/exec/ExecFuture.php

src/future/exec/__tests__/ExecFutureTestCase.php

src/workflow/ArcanistWorkflow.php

Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic
Actions

Revision Contents
Changeset List

src/future/exec/tests/ExecFutureTestCase.php