Page MenuHomePhabricator

Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic

Authored by epriestley on Feb 26 2020, 4:39 PM.

Details

Summary

Ref T11968. This future-level parameter has no nontrivial callers and makes the "fate of FutureGraph" changes more difficult.

Callers that are genuinely interested in this behavior can wrap the Future in a FutureIterator and use "setUpdateInterval()" to get the same behavior.

Test Plan

Grepped for "resolve()" and "resolvex()", updated callers.

Diff Detail

Repository
rARC Arcanist
Branch
fx1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/future/Future.php:35XHP62Class Name Literal
Unit
Tests Passed
Build Status
Buildable 23921
Build 32917: Run Core Tests
Build 32916: arc lint + arc unit