Page MenuHomePhabricator
Differential D21031

Remove the "timeout" parameter from "Future->resolve()"
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 4:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 8:46 AM
Unknown Object (File)
Sun, Feb 9, 8:46 AM
Unknown Object (File)
Sun, Feb 9, 8:46 AM
Unknown Object (File)
Tue, Jan 28, 5:31 AM
Unknown Object (File)
Tue, Jan 28, 5:31 AM
Unknown Object (File)
Tue, Jan 28, 5:31 AM
Unknown Object (File)
Sat, Jan 25, 4:40 PM
Unknown Object (File)
Sat, Jan 25, 6:46 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
Commits
rARC3df48c9257c3: Remove the "timeout" parameter from "Future->resolve()"
Summary

Ref T11968. This future-level parameter has no nontrivial callers and makes the "fate of FutureGraph" changes more difficult.

Callers that are genuinely interested in this behavior can wrap the Future in a FutureIterator and use "setUpdateInterval()" to get the same behavior.

Test Plan

Grepped for "resolve()" and "resolvex()", updated callers.

Diff Detail

Repository
rARC Arcanist
Branch
fx1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/future/Future.php:35XHP62Class Name Literal
Unit
Tests Passed
Build Status
Buildable 23921
Build 32917: Run Core Tests
Build 32916: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
future/
29 lines
4 lines
exec/
18 lines
__tests__/
9 lines
workflow/
4 lines

Diff 50100

View Options

src/future/Future.php

Loading...
View Options

src/future/FutureProxy.php

Loading...
View Options

src/future/exec/ExecFuture.php

Loading...
View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility