Page MenuHomePhabricator
Differential D20838

Add "PhutilProseDiff" classes to "phabricator/"
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 9:40 PM.
Tags
None
Referenced Files
F19178809: D20838.diff
Tue, Dec 16, 1:22 AM
F19151681: D20838.id49679.diff
Dec 10 2025, 10:35 PM
F19150494: D20838.id.diff
Dec 10 2025, 9:13 PM
F19139595: D20838.id49679.diff
Dec 10 2025, 11:57 AM
F19120222: D20838.id.diff
Dec 9 2025, 9:43 PM
F19083085: D20838.id49679.diff
Dec 2 2025, 12:30 PM
F19037579: D20838.diff
Nov 26 2025, 12:27 AM
F19030333: D20838.id49669.diff
Nov 24 2025, 8:53 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13395: Strip libphutil for parts
T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes
T13425: Support diffs between abstract block lists in the UI
Commits
rP9d884f144f01: Add "PhutilProseDiff" classes to "phabricator/"
Summary

Depends on D20836. Ref T13414. Ref T13425. Ref T13395. Move these to "phabricator/" before trying to improve the high-level diff engine in prose diffs.

Test Plan

Ran "arc liberate", looked at a prose diff (no behavioral change).

Diff Detail

Repository
rP Phabricator
Branch
jupyter9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23496
Build 32293: Run Core Tests
Build 32292: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
infrastructure/
diff/
prose/
292 lines
209 lines
__tests__/
245 lines

Diff 49669

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/infrastructure/diff/prose/PhutilProseDiff.php

Loading...
View Options

src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php

Loading...
View Options

src/infrastructure/diff/prose/__tests__/PhutilProseDiffTestCase.php

Loading...
Phabricator · Built by Phacility