Differential D20838

Add "PhutilProseDiff" classes to "phabricator/"
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 9:40 PM.

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes
T13425: Support diffs between abstract block lists in the UI
Commits: rP9d884f144f01: Add "PhutilProseDiff" classes to "phabricator/"

Summary

Depends on D20836. Ref T13414. Ref T13425. Ref T13395. Move these to "phabricator/" before trying to improve the high-level diff engine in prose diffs.

Test Plan

Ran "arc liberate", looked at a prose diff (no behavioral change).

Diff Detail

Repository

rP Phabricator

Branch

jupyter9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23496
Build 32293: Run Core Tests
Build 32292: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 25 2019, 9:40 PM

Harbormaster completed remote builds in B23496: Diff 49669.Sep 25 2019, 9:41 PM

epriestley requested review of this revision.Sep 25 2019, 9:41 PM

epriestley added a child revision: D20839: In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better.Sep 25 2019, 10:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:50 PM

Closed by commit rP9d884f144f01: Add "PhutilProseDiff" classes to "phabricator/" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9d884f144f01: Add "PhutilProseDiff" classes to "phabricator/".

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

infrastructure/

diff/

prose/

PhutilProseDiff.php

292 lines

PhutilProseDifferenceEngine.php

209 lines

__tests__/

PhutilProseDiffTestCase.php

245 lines

Diff 49669

View Options

src/__phutil_library_map__.php

View Options

src/infrastructure/diff/prose/PhutilProseDiff.php

View Options

src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php

View Options

src/infrastructure/diff/prose/tests/PhutilProseDiffTestCase.php

Add "PhutilProseDiff" classes to "phabricator/"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49669

src/__phutil_library_map__.php

src/infrastructure/diff/prose/PhutilProseDiff.php

src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php

src/infrastructure/diff/prose/__tests__/PhutilProseDiffTestCase.php

Add "PhutilProseDiff" classes to "phabricator/"
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/diff/prose/tests/PhutilProseDiffTestCase.php