Differential D20831

Render image diffs as abstract blocks diffs via DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 5:14 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rPbb71ef6ad6cd: Render image diffs as abstract blocks diffs via DocumentEngine

Summary

Depends on D20830. Ref T13425. Have the image engine elect into block rendering, then emit blocks.

This is rough (the blocks aren't actually diffed yet) but image diffs were already pretty rough so this is approximately a net improvement.

Test Plan

Viewed image diffs, saw nothing worse than before.

Diff Detail

Repository

rP Phabricator

Branch

jupyter2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/parser/DifferentialChangesetParser.php:1719	XHP16	TODO Comment
Advice	src/applications/differential/parser/DifferentialChangesetParser.php:1743	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23489
Build 32279: Run Core Tests
Build 32278: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 25 2019, 5:14 PM

Harbormaster completed remote builds in B23489: Diff 49662.Sep 25 2019, 5:16 PM

epriestley requested review of this revision.Sep 25 2019, 5:16 PM

epriestley added a child revision: D20832: Add a "View as..." option to diff dropdowns for selecting between document engines.Sep 25 2019, 5:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:25 PM

Closed by commit rPbb71ef6ad6cd: Render image diffs as abstract blocks diffs via DocumentEngine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPbb71ef6ad6cd: Render image diffs as abstract blocks diffs via DocumentEngine.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

__phutil_library_map__.php

applications/

differential/

parser/

DifferentialChangesetParser.php

202 lines

render/

DifferentialChangesetHTMLRenderer.php

13 lines

DifferentialChangesetOneUpMailRenderer.php

8 lines

DifferentialChangesetOneUpRenderer.php

27 lines

DifferentialChangesetRenderer.php

12 lines

DifferentialChangesetTestRenderer.php

10 lines

DifferentialChangesetTwoUpRenderer.php

83 lines

files/

diff/

PhabricatorDocumentEngineBlock.php

21 lines

PhabricatorDocumentEngineBlocks.php

83 lines

document/

PhabricatorImageDocumentEngine.php

44 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

4 lines

Diff 49662

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetTestRenderer.php

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

View Options

webroot/rsrc/css/application/differential/changeset-view.css

Render image diffs as abstract blocks diffs via DocumentEngineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49662

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

src/applications/differential/render/DifferentialChangesetOneUpMailRenderer.php

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

src/applications/differential/render/DifferentialChangesetRenderer.php

src/applications/differential/render/DifferentialChangesetTestRenderer.php

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

src/applications/files/document/PhabricatorImageDocumentEngine.php

webroot/rsrc/css/application/differential/changeset-view.css

Render image diffs as abstract blocks diffs via DocumentEngine
ClosedPublic
Actions

Revision Contents
Changeset List