Page MenuHomePhabricator

Render image diffs as abstract blocks diffs via DocumentEngine
ClosedPublic

Authored by epriestley on Sep 25 2019, 5:14 PM.
Tags
None
Referenced Files
F12826276: D20831.diff
Thu, Mar 28, 9:22 AM
Unknown Object (File)
Feb 3 2024, 11:14 PM
Unknown Object (File)
Jan 22 2024, 3:09 PM
Unknown Object (File)
Jan 6 2024, 1:06 PM
Unknown Object (File)
Nov 30 2023, 4:26 AM
Unknown Object (File)
Nov 17 2023, 7:57 AM
Unknown Object (File)
Nov 14 2023, 9:52 PM
Unknown Object (File)
Nov 12 2023, 11:20 PM
Subscribers
None

Details

Summary

Depends on D20830. Ref T13425. Have the image engine elect into block rendering, then emit blocks.

This is rough (the blocks aren't actually diffed yet) but image diffs were already pretty rough so this is approximately a net improvement.

Test Plan

Viewed image diffs, saw nothing worse than before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable