Page MenuHomePhabricator
Differential D20821

Generate more friendly anchor names for header sections in Remarkup
ClosedPublic
Actions

Authored by epriestley on Sep 18 2019, 10:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:57 AM
Unknown Object (File)
Sat, Dec 14, 7:45 PM
Unknown Object (File)
Tue, Dec 10, 5:24 PM
Unknown Object (File)
Tue, Dec 10, 8:58 AM
Unknown Object (File)
Sun, Dec 8, 6:59 PM
Unknown Object (File)
Sun, Dec 8, 9:50 AM
Unknown Object (File)
Thu, Dec 5, 3:49 PM
Unknown Object (File)
Tue, Dec 3, 7:11 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13410: Update Phriction UI structural behaviors
Commits
rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup
Summary

Depends on D20820. Ref T13410. We currently cut anchor names in the middle, don't support emoji in anchors, and generate relatively short anchors.

Generate slightly longer anchors, allow more unicode, and try not to cut things in the middle.

Test Plan

Created a document with a variety of different anchors and saw them generate more usable names.

Diff Detail

Repository
rP Phabricator
Branch
anchor2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23473
Build 32255: Run Core Tests
Build 32254: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 18 2019, 10:23 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2019, 10:25 PM
Harbormaster failed remote builds in B23466: Diff 49640!
epriestley updated this revision to Diff 49645.Sep 24 2019, 3:56 PM
  • Fix library map.
  • Add test coverage.
  • Clean up a few behaviors.
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 24 2019, 3:57 PM
Harbormaster failed remote builds in B23472: Diff 49645!
epriestley updated this revision to Diff 49646.Sep 24 2019, 4:07 PM
  • Fix tests and provide an explicit anchor rendering mode.
Harbormaster completed remote builds in B23473: Diff 49646.Sep 24 2019, 4:09 PM
epriestley requested review of this revision.Sep 24 2019, 4:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:03 PM
Closed by commit rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
__tests__/
38 lines
blockrule/
70 lines
markuprule/
4 lines
remarkup/
4 lines
__tests__/
remarkup/
6 lines

Diff 49646

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/infrastructure/markup/__tests__/PhabricatorAnchorTestCase.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupBoldRule.php

Loading...
View Options

src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php

Loading...
View Options

src/infrastructure/markup/remarkup/__tests__/remarkup/toc.txt

Loading...
Phabricator · Built by Phacility