Differential D20821

Generate more friendly anchor names for header sections in Remarkup
ClosedPublic
Actions

Authored by epriestley on Sep 18 2019, 10:23 PM.

Tags

None

Referenced Files

	F14074941: D20821.id49640.diff
	Thu, Nov 21, 9:19 AM

	Unknown Object (File)
	Fri, Nov 15, 10:08 PM

	Unknown Object (File)
	Tue, Nov 12, 7:57 PM

	Unknown Object (File)
	Thu, Oct 31, 8:02 PM

	Unknown Object (File)
	Sun, Oct 27, 12:48 AM

	Unknown Object (File)
	Oct 22 2024, 1:42 AM

	Unknown Object (File)
	Oct 20 2024, 4:49 AM

	Unknown Object (File)
	Oct 13 2024, 7:09 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13410: Update Phriction UI structural behaviors
Commits: rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup

Summary

Depends on D20820. Ref T13410. We currently cut anchor names in the middle, don't support emoji in anchors, and generate relatively short anchors.

Generate slightly longer anchors, allow more unicode, and try not to cut things in the middle.

Test Plan

Created a document with a variety of different anchors and saw them generate more usable names.

Diff Detail

Repository

Branch

anchor2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23472
Build 32253: Run Core Tests
Build 32252: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	256 ms	PhutilRemarkupEngineTestCase::testEngine Assertion failed, expected values to be equal (at PhutilRemarkupEngineTestCase.php:67): Failed to markup HTML in file 'toc.txt'. Expected vs Actual Output Diff --- Old Value
	1 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames 2 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPSinkBasics 3 assertions passed.
		View Full Test Results (1 Failed · 392 Passed)

Event Timeline

epriestley created this revision.Sep 18 2019, 10:23 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2019, 10:25 PM

Harbormaster failed remote builds in B23466: Diff 49640!

Fix library map.
Add test coverage.
Clean up a few behaviors.

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 24 2019, 3:57 PM

Harbormaster failed remote builds in B23472: Diff 49645!

Fix tests and provide an explicit anchor rendering mode.

Harbormaster completed remote builds in B23473: Diff 49646.Sep 24 2019, 4:09 PM

epriestley requested review of this revision.Sep 24 2019, 4:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:03 PM

Closed by commit rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

infrastructure/

markup/

__tests__/

PhabricatorAnchorTestCase.php

38 lines

blockrule/

PhutilRemarkupHeaderBlockRule.php

70 lines

Diff 49645

src/__phutil_library_map__.php

Loading...

src/infrastructure/markup/tests/PhabricatorAnchorTestCase.php

Loading...

src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php

Loading...