Page MenuHomePhabricator

Allow a user to target "#anchor" by navigating to any prefix
ClosedPublic

Authored by epriestley on Sep 18 2019, 10:02 PM.

Details

Summary

Ref T13410. We currently generate some less-than-ideal anchors in remarkup, but it's hard to change the algorithm without breaking stuff.

To mitigate this, allow #xyz to match any target on the page which begins with xyz. This means we can make anchors longer with no damage, and savvy users are free to shorten anchors to produce more presentation-friendly links.

Test Plan

Browsed to #header-th, was scrolled to #header-three, etc.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 18 2019, 10:02 PM
epriestley requested review of this revision.Sep 18 2019, 10:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 5:56 PM
This revision was automatically updated to reflect the committed changes.