Page MenuHomePhabricator

Generate more friendly anchor names for header sections in Remarkup
ClosedPublic

Authored by epriestley on Wed, Sep 18, 10:23 PM.

Details

Summary

Depends on D20820. Ref T13410. We currently cut anchor names in the middle, don't support emoji in anchors, and generate relatively short anchors.

Generate slightly longer anchors, allow more unicode, and try not to cut things in the middle.

Test Plan

Created a document with a variety of different anchors and saw them generate more usable names.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Sep 18, 10:23 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Sep 18, 10:25 PM
Harbormaster failed remote builds in B23466: Diff 49640!
epriestley updated this revision to Diff 49645.Tue, Sep 24, 3:56 PM
  • Fix library map.
  • Add test coverage.
  • Clean up a few behaviors.
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Sep 24, 3:57 PM
Harbormaster failed remote builds in B23472: Diff 49645!
epriestley updated this revision to Diff 49646.Tue, Sep 24, 4:07 PM
  • Fix tests and provide an explicit anchor rendering mode.
epriestley requested review of this revision.Tue, Sep 24, 4:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 24, 6:03 PM
This revision was automatically updated to reflect the committed changes.