Page MenuHomePhabricator

Generate more friendly anchor names for header sections in Remarkup
ClosedPublic

Authored by epriestley on Sep 18 2019, 10:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:53 AM
Unknown Object (File)
Feb 12 2024, 5:44 AM
Unknown Object (File)
Feb 11 2024, 9:25 PM
Unknown Object (File)
Dec 30 2023, 4:50 PM
Unknown Object (File)
Dec 26 2023, 5:56 PM
Unknown Object (File)
Dec 26 2023, 12:45 PM
Unknown Object (File)
Dec 23 2023, 12:46 AM
Unknown Object (File)
Dec 22 2023, 7:26 PM
Subscribers
None

Details

Summary

Depends on D20820. Ref T13410. We currently cut anchor names in the middle, don't support emoji in anchors, and generate relatively short anchors.

Generate slightly longer anchors, allow more unicode, and try not to cut things in the middle.

Test Plan

Created a document with a variety of different anchors and saw them generate more usable names.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2019, 10:25 PM
Harbormaster failed remote builds in B23466: Diff 49640!
  • Fix library map.
  • Add test coverage.
  • Clean up a few behaviors.
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 24 2019, 3:57 PM
Harbormaster failed remote builds in B23472: Diff 49645!
  • Fix tests and provide an explicit anchor rendering mode.
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:03 PM
This revision was automatically updated to reflect the committed changes.