Generate more friendly anchor names for header sections in Remarkup
ClosedPublic
Actions

Authored by epriestley on Sep 18 2019, 10:23 PM.

Details

Reviewers: None
Maniphest Tasks: T13410: Update Phriction UI structural behaviors
Commits: rPbff72ce3b582: Generate more friendly anchor names for header sections in Remarkup

Summary

Depends on D20820. Ref T13410. We currently cut anchor names in the middle, don't support emoji in anchors, and generate relatively short anchors.

Generate slightly longer anchors, allow more unicode, and try not to cut things in the middle.

Test Plan

Created a document with a variety of different anchors and saw them generate more usable names.

Repository

rP Phabricator

Branch

anchor2

Lint

Lint Passed

Unit

Tests Passed

Build Status

	Time	Test
	240 ms	PhutilRemarkupEngineTestCase::testEngine Assertion failed, expected values to be equal (at PhutilRemarkupEngineTestCase.php:67): Failed to markup HTML in file 'toc.txt'. Expected vs Actual Output Diff --- Old Value
	1 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames 2 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPSinkBasics 3 assertions passed.
		View Full Test Results (1 Failed · 390 Passed)