Differential D20672

Give user log types a tokenizer and datasource instead of a page of checkboxes
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 9:51 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion

Commits

rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes

Summary

Depends on D20671. Ref T13343. Now that log types are modular, provide a datasource/tokenizer for selecting them since we already have a lot (even after I purged a few in D20670) and I'm planning to add at least one more ("Request password reset").

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

elogin11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23166
Build 31821: Run Core Tests
Build 31820: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 19 2019, 9:51 PM

Harbormaster completed remote builds in B23166: Diff 49299.Jul 19 2019, 9:53 PM

epriestley requested review of this revision.Jul 19 2019, 9:53 PM

epriestley added a child revision: D20673: Record account recovery email links in the user activity log and make the mail message reference the log.Jul 19 2019, 10:05 PM

amckinley accepted this revision.Jul 22 2019, 10:59 PM

This revision is now accepted and ready to land.Jul 22 2019, 10:59 PM

Closed by commit rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes (authored by epriestley). · Explain WhyJul 24 2019, 2:11 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

people/

query/

PhabricatorPeopleLogSearchEngine.php

4 lines

typeahead/

PhabricatorUserLogTypeDatasource.php

43 lines

Diff 49299

View Options

src/__phutil_library_map__.php

View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

View Options

src/applications/people/typeahead/PhabricatorUserLogTypeDatasource.php

Give user log types a tokenizer and datasource instead of a page of checkboxesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49299

src/__phutil_library_map__.php

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

src/applications/people/typeahead/PhabricatorUserLogTypeDatasource.php

Give user log types a tokenizer and datasource instead of a page of checkboxes
ClosedPublic
Actions

Revision Contents
Changeset List