Page MenuHomePhabricator
Differential D20672

Give user log types a tokenizer and datasource instead of a page of checkboxes
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 9:51 PM.
Tags
None
Referenced Files
F19511196: D20672.id49318.diff
Sun, Jan 11, 11:11 PM
F19510980: D20672.diff
Sun, Jan 11, 7:11 PM
F19501178: D20672.id49318.diff
Thu, Jan 8, 3:05 PM
F19469160: D20672.id.diff
Sun, Jan 4, 5:06 PM
F19467958: D20672.diff
Sat, Jan 3, 8:26 PM
F18839556: D20672.id.diff
Oct 27 2025, 5:11 PM
F18836020: D20672.diff
Oct 26 2025, 8:53 PM
F18804155: D20672.id49318.diff
Oct 18 2025, 6:23 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion
Commits
rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes
Summary

Depends on D20671. Ref T13343. Now that log types are modular, provide a datasource/tokenizer for selecting them since we already have a lot (even after I purged a few in D20670) and I'm planning to add at least one more ("Request password reset").

Test Plan

Screen Shot 2019-07-19 at 2.51.02 PM.png (232×1 px, 37 KB)

Diff Detail

Repository
rP Phabricator
Branch
elogin11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23166
Build 31821: Run Core Tests
Build 31820: arc lint + arc unit

Revision Contents
Changeset List

Diff 49299

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorUserLogTypeDatasource.php

Loading...
Phabricator · Built by Phacility