Page MenuHomePhabricator
Differential D20672

Give user log types a tokenizer and datasource instead of a page of checkboxes
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 9:51 PM.
Tags
None
Referenced Files
F15529166: D20672.id49318.diff
Tue, Apr 22, 5:22 PM
F15513426: D20672.id.diff
Thu, Apr 17, 7:01 PM
F15510416: D20672.diff
Wed, Apr 16, 8:03 PM
F15462492: D20672.diff
Tue, Apr 1, 3:26 PM
F15456289: D20672.diff
Sun, Mar 30, 8:26 AM
F15445258: D20672.diff
Thu, Mar 27, 1:09 PM
F15429087: D20672.id49299.diff
Mar 24 2025, 12:29 AM
F15428686: D20672.id.diff
Mar 23 2025, 9:41 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion
Commits
rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes
Summary

Depends on D20671. Ref T13343. Now that log types are modular, provide a datasource/tokenizer for selecting them since we already have a lot (even after I purged a few in D20670) and I'm planning to add at least one more ("Request password reset").

Test Plan

Screen Shot 2019-07-19 at 2.51.02 PM.png (232×1 px, 37 KB)

Diff Detail

Repository
rP Phabricator
Branch
elogin11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23166
Build 31821: Run Core Tests
Build 31820: arc lint + arc unit

Revision Contents
Changeset List

Diff 49299

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorUserLogTypeDatasource.php

Loading...
Phabricator · Built by Phacility