Paths

Table of Contentst

Differential D20669

Simplify implementation of "SysetemAction->getSystemActionConstant()"
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 5:27 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion

Commits

rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()"

Summary

Depends on D20668. Ref T13343. Just an easy cleanup/simplification while I'm here.

Test Plan

grep for getActionConstant()

Diff Detail

Repository

rP Phabricator

Branch

elogin8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23163
Build 31815: Run Core Tests
Build 31814: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 19 2019, 5:27 PM

Harbormaster completed remote builds in B23163: Diff 49296.Jul 19 2019, 5:29 PM

epriestley requested review of this revision.Jul 19 2019, 5:29 PM

epriestley added a child revision: D20670: Remove explicit administrative actions from the user activity log.Jul 19 2019, 6:17 PM

amckinley accepted this revision.Jul 19 2019, 9:44 PM

This revision is now accepted and ready to land.Jul 19 2019, 9:44 PM

Closed by commit rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()" (authored by epriestley). · Explain WhyJul 19 2019, 10:45 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()".

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

action/

PhabricatorAuthChangePasswordAction.php

4 lines

PhabricatorAuthEmailLoginAction.php

4 lines

PhabricatorAuthNewFactorAction.php

4 lines

PhabricatorAuthTestSMSAction.php

4 lines

PhabricatorAuthTryEmailLoginAction.php

4 lines

PhabricatorAuthTryFactorAction.php

4 lines

PhabricatorAuthTryPasswordAction.php

4 lines

PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

4 lines

files/

action/

PhabricatorFilesOutboundRequestAction.php

4 lines

metamta/

action/

PhabricatorMetaMTAErrorMailAction.php

4 lines

phortune/

action/

PhortuneAddPaymentMethodAction.php

4 lines

settings/

action/

PhabricatorSettingsAddEmailAction.php

4 lines

system/

action/

PhabricatorSystemAction.php

5 lines

Diff 49296

View Options

src/applications/auth/action/PhabricatorAuthChangePasswordAction.php

View Options

src/applications/auth/action/PhabricatorAuthEmailLoginAction.php

View Options

src/applications/auth/action/PhabricatorAuthNewFactorAction.php

View Options

src/applications/auth/action/PhabricatorAuthTestSMSAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryEmailLoginAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryFactorAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryPasswordAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

View Options

src/applications/files/action/PhabricatorFilesOutboundRequestAction.php

View Options

src/applications/metamta/action/PhabricatorMetaMTAErrorMailAction.php

View Options

src/applications/phortune/action/PhortuneAddPaymentMethodAction.php

View Options

src/applications/settings/action/PhabricatorSettingsAddEmailAction.php

View Options

src/applications/system/action/PhabricatorSystemAction.php

Simplify implementation of "SysetemAction->getSystemActionConstant()"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49296

src/applications/auth/action/PhabricatorAuthChangePasswordAction.php

src/applications/auth/action/PhabricatorAuthEmailLoginAction.php

src/applications/auth/action/PhabricatorAuthNewFactorAction.php

src/applications/auth/action/PhabricatorAuthTestSMSAction.php

src/applications/auth/action/PhabricatorAuthTryEmailLoginAction.php

src/applications/auth/action/PhabricatorAuthTryFactorAction.php

src/applications/auth/action/PhabricatorAuthTryPasswordAction.php

src/applications/auth/action/PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

src/applications/files/action/PhabricatorFilesOutboundRequestAction.php

src/applications/metamta/action/PhabricatorMetaMTAErrorMailAction.php

src/applications/phortune/action/PhortuneAddPaymentMethodAction.php

src/applications/settings/action/PhabricatorSettingsAddEmailAction.php

src/applications/system/action/PhabricatorSystemAction.php

Simplify implementation of "SysetemAction->getSystemActionConstant()"
ClosedPublic
Actions

Revision Contents
Changeset List