Page MenuHomePhabricator

Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both
ClosedPublic

Authored by epriestley on Jul 19 2019, 4:27 PM.
Tags
None
Referenced Files
F15415550: D20665.id49292.diff
Thu, Mar 20, 6:37 AM
F15412128: D20665.id49292.diff
Wed, Mar 19, 11:25 AM
F15382258: D20665.diff
Fri, Mar 14, 11:32 AM
Unknown Object (File)
Feb 18 2025, 7:49 AM
Unknown Object (File)
Feb 10 2025, 1:02 AM
Unknown Object (File)
Feb 10 2025, 1:02 AM
Unknown Object (File)
Feb 10 2025, 1:02 AM
Unknown Object (File)
Feb 2 2025, 8:45 PM
Subscribers
None

Details

Summary

Depends on D20664. Ref T13343. There's a reasonable value for the default "Email Login" auth message (generic "you reset your password" text) that installs may reasonably want to replace. Add support for a default value.

Also, since it isn't completely obvious where this message shows up, add support for an extended description and explain what's going on in more detail.

Test Plan
  • Viewed message detail page, saw more detailed information.
  • Sent mail (got default), overrode message and sent mail (got custom message), deleted message (got default again).

Diff Detail

Repository
rP Phabricator
Branch
elogin4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23159
Build 31807: Run Core Tests
Build 31806: arc lint + arc unit