Differential D20665

Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both
ClosedPublic
Actions

Authored by epriestley on Jul 19 2019, 4:27 PM.

Tags

None

Referenced Files

	F13050967: D20665.id49305.diff
	Fri, Apr 19, 3:17 AM

	F13050966: D20665.id49292.diff
	Fri, Apr 19, 3:17 AM

	F13050965: D20665.id.diff
	Fri, Apr 19, 3:17 AM

	Unknown Object (File)
	Wed, Apr 17, 10:49 PM

	Unknown Object (File)
	Thu, Apr 11, 9:11 AM

	Unknown Object (File)
	Thu, Apr 11, 4:27 AM

	Unknown Object (File)
	Fri, Apr 5, 4:16 AM

	Unknown Object (File)
	Sat, Mar 30, 8:27 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion

Commits

rPced416cc735a: Allow Auth messages to have detailed descriptions and default values, then give…

Summary

Depends on D20664. Ref T13343. There's a reasonable value for the default "Email Login" auth message (generic "you reset your password" text) that installs may reasonably want to replace. Add support for a default value.

Also, since it isn't completely obvious where this message shows up, add support for an extended description and explain what's going on in more detail.

Test Plan

Viewed message detail page, saw more detailed information.
Sent mail (got default), overrode message and sent mail (got custom message), deleted message (got default again).

Diff Detail

Repository

Branch

elogin4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23159
Build 31807: Run Core Tests
Build 31806: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 19 2019, 4:27 PM

Harbormaster completed remote builds in B23159: Diff 49292.Jul 19 2019, 4:29 PM

epriestley requested review of this revision.Jul 19 2019, 4:29 PM

epriestley added a child revision: D20666: Add a rate limit to generating new account recovery links for a given account.Jul 19 2019, 4:42 PM

amckinley accepted this revision.Jul 19 2019, 9:40 PM

This revision is now accepted and ready to land.Jul 19 2019, 9:40 PM

Closed by commit rPced416cc735a: Allow Auth messages to have detailed descriptions and default values, then give… (authored by epriestley). · Explain WhyJul 19 2019, 10:39 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPced416cc735a: Allow Auth messages to have detailed descriptions and default values, then give….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

message/

PhabricatorAuthMessageViewController.php

27 lines

message/

PhabricatorAuthEmailLoginMessageType.php

23 lines

PhabricatorAuthMessageType.php

8 lines

storage/

PhabricatorAuthMessage.php

12 lines

people/

mail/

PhabricatorPeopleMailEngine.php

5 lines

Diff 49292

src/applications/auth/controller/message/PhabricatorAuthMessageViewController.php

Loading...

src/applications/auth/message/PhabricatorAuthEmailLoginMessageType.php

Loading...

src/applications/auth/message/PhabricatorAuthMessageType.php

Loading...

src/applications/auth/storage/PhabricatorAuthMessage.php

Loading...

src/applications/people/mail/PhabricatorPeopleMailEngine.php

Loading...