Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
F15383983: D20196.diff
Fri, Mar 14, 6:30 PM
F15360822: D20196.id48228.diff
Tue, Mar 11, 10:26 AM
Unknown Object (File)
Fri, Feb 28, 10:05 PM
Unknown Object (File)
Fri, Feb 21, 12:56 AM
Unknown Object (File)
Feb 15 2025, 7:09 PM
Unknown Object (File)
Feb 12 2025, 10:25 PM
Unknown Object (File)
Feb 10 2025, 3:11 AM
Unknown Object (File)
Feb 9 2025, 7:15 AM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22080
Build 30160: Run Core Tests
Build 30159: arc lint + arc unit