Page MenuHomePhabricator
Files F15420088

D20196.diff
No OneTemporary
Actions

D20196.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,8 +11,8 @@
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => 'e3c1a8f2',
'core.pkg.js' => '2cda17a4',
- 'differential.pkg.css' => '9f215e54',
- 'differential.pkg.js' => '53f8d00c',
+ 'differential.pkg.css' => '97e13037',
+ 'differential.pkg.js' => '67e02996',
'diffusion.pkg.css' => '42c75c37',
'diffusion.pkg.js' => '91192d85',
'maniphest.pkg.css' => '35995d6d',
@@ -62,7 +62,7 @@
'rsrc/css/application/diff/inline-comment-summary.css' => '81eb368d',
'rsrc/css/application/differential/add-comment.css' => '7e5900d9',
'rsrc/css/application/differential/changeset-view.css' => 'de570228',
- 'rsrc/css/application/differential/core.css' => 'bdb93065',
+ 'rsrc/css/application/differential/core.css' => '7300a73e',
'rsrc/css/application/differential/phui-inline-comment.css' => '48acce5b',
'rsrc/css/application/differential/revision-comment.css' => '7dbc8d1d',
'rsrc/css/application/differential/revision-history.css' => '8aa3eac5',
@@ -380,7 +380,6 @@
'rsrc/js/application/diff/behavior-preview-link.js' => 'f51e9c17',
'rsrc/js/application/differential/behavior-diff-radios.js' => '925fe8cd',
'rsrc/js/application/differential/behavior-populate.js' => 'dfa1d313',
- 'rsrc/js/application/differential/behavior-user-select.js' => 'e18685c0',
'rsrc/js/application/diffusion/DiffusionLocateFileSource.js' => '94243d89',
'rsrc/js/application/diffusion/behavior-audit-preview.js' => 'b7b73831',
'rsrc/js/application/diffusion/behavior-commit-branches.js' => '4b671572',
@@ -542,7 +541,7 @@
'conpherence-transaction-css' => '3a3f5e7e',
'd3' => 'd67475f5',
'differential-changeset-view-css' => 'de570228',
- 'differential-core-view-css' => 'bdb93065',
+ 'differential-core-view-css' => '7300a73e',
'differential-revision-add-comment-css' => '7e5900d9',
'differential-revision-comment-css' => '7dbc8d1d',
'differential-revision-history-css' => '8aa3eac5',
@@ -596,7 +595,6 @@
'javelin-behavior-diff-preview-link' => 'f51e9c17',
'javelin-behavior-differential-diff-radios' => '925fe8cd',
'javelin-behavior-differential-populate' => 'dfa1d313',
- 'javelin-behavior-differential-user-select' => 'e18685c0',
'javelin-behavior-diffusion-commit-branches' => '4b671572',
'javelin-behavior-diffusion-commit-graph' => '1c88f154',
'javelin-behavior-diffusion-locate-file' => '87428eb2',
@@ -2030,11 +2028,6 @@
'javelin-dom',
'javelin-history',
),
- 'e18685c0' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-stratcom',
- ),
'e562708c' => array(
'javelin-install',
),
@@ -2339,7 +2332,6 @@
'javelin-behavior-aphront-drag-and-drop-textarea',
'javelin-behavior-phabricator-object-selector',
'javelin-behavior-repository-crossreference',
- 'javelin-behavior-differential-user-select',
'javelin-behavior-aphront-more',
'phabricator-diff-inline',
'phabricator-diff-changeset',
diff --git a/resources/celerity/packages.php b/resources/celerity/packages.php
--- a/resources/celerity/packages.php
+++ b/resources/celerity/packages.php
@@ -199,7 +199,6 @@
'javelin-behavior-phabricator-object-selector',
'javelin-behavior-repository-crossreference',
- 'javelin-behavior-differential-user-select',
'javelin-behavior-aphront-more',
'phabricator-diff-inline',
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -621,8 +621,6 @@
->build($changesets);
}
- Javelin::initBehavior('differential-user-select');
-
$view = id(new PHUITwoColumnView())
->setHeader($header)
->setSubheader($subheader)
diff --git a/webroot/rsrc/css/application/differential/core.css b/webroot/rsrc/css/application/differential/core.css
--- a/webroot/rsrc/css/application/differential/core.css
+++ b/webroot/rsrc/css/application/differential/core.css
@@ -16,14 +16,6 @@
margin-bottom: 8px;
}
-.differential-unselectable tr td:nth-of-type(1) {
- -moz-user-select: -moz-none;
- -khtml-user-select: none;
- -webkit-user-select: none;
- -ms-user-select: none;
- user-select: none;
-}
-
.differential-content-hidden {
margin: 0 0 24px 0;
}
diff --git a/webroot/rsrc/js/application/differential/behavior-user-select.js b/webroot/rsrc/js/application/differential/behavior-user-select.js
deleted file mode 100644
--- a/webroot/rsrc/js/application/differential/behavior-user-select.js
+++ /dev/null
@@ -1,33 +0,0 @@
-/**
- * @provides javelin-behavior-differential-user-select
- * @requires javelin-behavior
- * javelin-dom
- * javelin-stratcom
- */
-
-JX.behavior('differential-user-select', function() {
-
- var unselectable;
-
- function isOnRight(node) {
- return node.previousSibling &&
- node.parentNode.firstChild != node.previousSibling;
- }
-
- JX.Stratcom.listen(
- 'mousedown',
- null,
- function(e) {
- var key = 'differential-unselectable';
- if (unselectable) {
- JX.DOM.alterClass(unselectable, key, false);
- }
- var diff = e.getNode('differential-diff');
- var td = e.getNode('tag:td');
- if (diff && td && isOnRight(td)) {
- unselectable = diff;
- JX.DOM.alterClass(diff, key, true);
- }
- });
-
-});

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 22, 11:13 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7583193
Default Alt Text
D20196.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility