Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
F18423683: D20196.id48223.diff
Sat, Aug 30, 7:54 PM
F18415340: D20196.id.diff
Sat, Aug 30, 9:35 AM
F18414127: D20196.id48223.diff
Sat, Aug 30, 8:16 AM
F18413007: D20196.id48228.diff
Sat, Aug 30, 7:09 AM
F18412489: D20196.diff
Sat, Aug 30, 6:41 AM
F18412351: D20196.diff
Sat, Aug 30, 6:35 AM
F18143854: D20196.id48228.diff
Thu, Aug 14, 2:50 PM
F18112855: D20196.id.diff
Aug 12 2025, 9:28 PM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable