Page MenuHomePhabricator

Remove an old Differential selection behavior
ClosedPublic

Authored by epriestley on Feb 20 2019, 4:58 AM.
Tags
None
Referenced Files
F13098055: D20196.diff
Fri, Apr 26, 3:54 AM
Unknown Object (File)
Wed, Apr 24, 9:49 PM
Unknown Object (File)
Sun, Apr 21, 3:39 PM
Unknown Object (File)
Wed, Apr 17, 2:28 PM
Unknown Object (File)
Thu, Apr 11, 6:55 AM
Unknown Object (File)
Mar 20 2024, 12:00 PM
Unknown Object (File)
Mar 10 2024, 5:07 AM
Unknown Object (File)
Feb 3 2024, 9:28 PM
Subscribers
None

Details

Summary

Ref T12822. Ref PHI878. This is some leftover code from the old selection behavior that prevented visual selection of the left side of a diff if the user clicked on the right -- basically, a much simpler attack on what ultimately landed in D20191.

I think the change from th to td "broke" it so it didn't interfere with the other behavior, which is why I didn't have to remove it earlier. It's no longer necessary, in any case.

Test Plan

Grepped for behavior name, selected stuff on both sides of a diff.

Diff Detail

Repository
rP Phabricator
Branch
diff2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22080
Build 30160: Run Core Tests
Build 30159: arc lint + arc unit