Page MenuHomePhabricator

Allow users to register with non-registration providers if they are invited to an instance
ClosedPublic

Authored by epriestley on Feb 7 2019, 2:04 AM.
Tags
None
Referenced Files
F14417401: D20118.id48131.diff
Wed, Dec 25, 12:57 AM
F14411781: D20118.diff
Tue, Dec 24, 12:13 PM
Unknown Object (File)
Thu, Dec 19, 5:43 PM
Unknown Object (File)
Thu, Dec 12, 12:16 AM
Unknown Object (File)
Wed, Dec 11, 4:51 PM
Unknown Object (File)
Sun, Dec 8, 8:48 AM
Unknown Object (File)
Wed, Dec 4, 11:39 AM
Unknown Object (File)
Sat, Nov 30, 4:06 PM
Subscribers
None

Details

Summary

Depends on D20117. Fixes T10071. When you're sent an email invitation, it's intended to allow you to register an account even if you otherwise could not (see D11737).

Some time between D11737 and today, this stopped working (or perhaps it never worked and I got things wrong in D11737). I think this actually ended up not mattering for us, given the way Phacility auth was ultimately built.

This feature generally seems reasonable, though, and probably should work. Make it work in the "password" and "oauth" cases, at least. This may still not work for LDAP, but testing that is nontrivial.

Test Plan
  • Enabled only passwords, turned off registration, sent an invite, registered with a password.
  • Enabled only Google OAuth, turned off registration, sent an invite, registered with Google OAuth.

Diff Detail

Repository
rP Phabricator
Branch
xacc8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21873
Build 29855: Run Core Tests
Build 29854: arc lint + arc unit