Page MenuHomePhabricator

Support invites in the registration and login flow
ClosedPublic

Authored by epriestley on Feb 10 2015, 10:25 PM.
Tags
None
Referenced Files
F14019100: D11737.id28302.diff
Tue, Nov 5, 9:33 PM
F14019099: D11737.id28278.diff
Tue, Nov 5, 9:33 PM
F14019098: D11737.id28277.diff
Tue, Nov 5, 9:33 PM
F14019096: D11737.id.diff
Tue, Nov 5, 9:33 PM
F14016477: D11737.diff
Mon, Nov 4, 9:53 AM
F14014892: D11737.diff
Sun, Nov 3, 9:21 AM
F14003749: D11737.id28278.diff
Sat, Oct 26, 10:17 AM
F14003748: D11737.id28277.diff
Sat, Oct 26, 10:17 AM
Subscribers

Details

Summary

Ref T7152. This substantially completes the upstream login flow. Basically, we just cookie you and push you through normal registration, with slight changes:

  • All providers allow registration if you have an invite.
  • Most providers get minor text changes to say "Register" instead of "Login" or "Login or Register".
  • The Username/Password provider changes to just a "choose a username" form.
  • We show the user that they're accepting an invite, and who invited them.

Then on actual registration:

  • Accepting an invite auto-verifies the address.
  • Accepting an invite auto-approves the account.
  • Your email is set to the invite email and locked.
  • Invites get to reassign nonprimary, unverified addresses from other accounts.

But 98% of the code is the same.

Test Plan
  • Accepted an invite.
  • Verified a new address on an existing account via invite.
  • Followed a bad invite link.
  • Tried to accept a verified invite.
  • Reassigned an email by accepting an unverified, nonprimary invite on a new account.
  • Verified that reassigns appear in the activity log.

Screen_Shot_2015-02-10_at_2.19.03_PM.png (659×1 px, 158 KB)

Screen_Shot_2015-02-10_at_2.16.01_PM.png (738×1 px, 126 KB)

Screen_Shot_2015-02-10_at_2.16.09_PM.png (738×1 px, 142 KB)

Screen_Shot_2015-02-10_at_2.16.18_PM.png (1×1 px, 159 KB)

Screen_Shot_2015-02-10_at_2.15.45_PM.png (644×1 px, 109 KB)

Screen_Shot_2015-02-10_at_2.15.36_PM.png (633×1 px, 108 KB)

Screen_Shot_2015-02-10_at_2.15.12_PM.png (633×1 px, 109 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support invites in the registration and login flow.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Looks great!

This revision is now accepted and ready to land.Feb 10 2015, 11:31 PM
This revision was automatically updated to reflect the committed changes.