Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
F15540197: D20117.id.diff
Fri, Apr 25, 6:45 AM
F15538574: D20117.diff
Thu, Apr 24, 8:05 PM
F15470536: D20117.id.diff
Fri, Apr 4, 11:18 PM
F15454313: D20117.diff
Sat, Mar 29, 5:52 PM
F15440017: D20117.id48032.diff
Mar 26 2025, 10:45 AM
F15434866: D20117.id.diff
Mar 25 2025, 5:46 AM
F15433401: D20117.diff
Mar 24 2025, 11:00 PM
F15431725: D20117.id.diff
Mar 24 2025, 2:08 PM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Branch
xacc7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21872
Build 29853: Run Core Tests
Build 29852: arc lint + arc unit