Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 29 2026, 11:05 PM
Unknown Object (File)
Jun 5 2026, 4:44 AM
Unknown Object (File)
Apr 18 2026, 1:08 PM
Unknown Object (File)
Apr 12 2026, 9:17 PM
Unknown Object (File)
Apr 11 2026, 7:24 PM
Unknown Object (File)
Mar 18 2026, 3:34 AM
Unknown Object (File)
Mar 18 2026, 3:34 AM
Unknown Object (File)
Mar 3 2026, 9:01 PM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Branch
xacc7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21872
Build 29853: Run Core Tests
Build 29852: arc lint + arc unit