Page MenuHomePhabricator
Differential D20113

Make external account unlinking use account IDs, not "providerType + providerDomain" nonsense
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:02 AM.
Tags
None
Referenced Files
F15472633: D20113.id48022.diff
Sat, Apr 5, 3:09 PM
F15471786: D20113.diff
Sat, Apr 5, 8:06 AM
F15470532: D20113.id.diff
Fri, Apr 4, 11:18 PM
F15465916: D20113.id48022.diff
Thu, Apr 3, 12:16 AM
F15462297: D20113.id.diff
Tue, Apr 1, 1:47 PM
F15451717: D20113.id48022.diff
Fri, Mar 28, 11:31 PM
F15445773: D20113.id48129.diff
Thu, Mar 27, 3:58 PM
F15440935: D20113.id.diff
Wed, Mar 26, 3:33 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T6703: Allow multiple copies of the same auth provider type
Commits
rPe5ee656fff0c: Make external account unlinking use account IDs, not "providerType +…
Summary

Depends on D20112. Ref T6703. When you go to unlink an account, unlink it by ID. Crazy!

Test Plan

Unlinked and relinked Google accounts.

Diff Detail

Repository
rP Phabricator
Branch
welcome16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21862
Build 29837: Run Core Tests
Build 29836: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
application/
2 lines
controller/
119 lines
settings/
panel/
2 lines

Diff 48022

View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthUnlinkController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

Loading...
Phabricator · Built by Phacility