Page MenuHomePhabricator
Differential D20113

Make external account unlinking use account IDs, not "providerType + providerDomain" nonsense
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:02 AM.
Tags
None
Referenced Files
F17969848: D20113.id.diff
Fri, Aug 1, 2:28 PM
F17946305: D20113.diff
Thu, Jul 31, 2:11 PM
F17860242: D20113.diff
Sun, Jul 27, 9:38 PM
Unknown Object (File)
May 31 2025, 5:01 AM
Unknown Object (File)
May 28 2025, 2:13 PM
Unknown Object (File)
May 27 2025, 1:28 PM
Unknown Object (File)
Apr 30 2025, 11:06 AM
Unknown Object (File)
Apr 29 2025, 10:04 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T6703: Allow multiple copies of the same auth provider type
Commits
rPe5ee656fff0c: Make external account unlinking use account IDs, not "providerType +…
Summary

Depends on D20112. Ref T6703. When you go to unlink an account, unlink it by ID. Crazy!

Test Plan

Unlinked and relinked Google accounts.

Diff Detail

Repository
rP Phabricator
Branch
welcome16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21862
Build 29837: Run Core Tests
Build 29836: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
application/
2 lines
controller/
119 lines
settings/
panel/
2 lines

Diff 48022

View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthUnlinkController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

Loading...
Phabricator · Built by Phacility