Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F19942564: D20107.diff
Wed, Apr 15, 7:56 PM
F19929331: D20107.diff
Wed, Apr 8, 3:50 PM
F19899955: D20107.id48016.diff
Mon, Mar 30, 12:41 AM
F19894529: D20107.diff
Sat, Mar 28, 3:19 PM
F19827812: D20107.id.diff
Mar 9 2026, 1:07 PM
F19824269: D20107.id48031.diff
Mar 7 2026, 9:01 PM
F19731111: D20107.id48015.diff
Feb 14 2026, 6:56 PM
F19603526: D20107.diff
Feb 3 2026, 7:20 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Branch
welcome10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21856
Build 29825: Run Core Tests
Build 29824: arc lint + arc unit