Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 9:05 AM
Unknown Object (File)
Feb 9 2024, 1:16 AM
Unknown Object (File)
Feb 3 2024, 9:11 PM
Unknown Object (File)
Jan 17 2024, 4:51 PM
Unknown Object (File)
Dec 26 2023, 5:37 AM
Unknown Object (File)
Dec 25 2023, 10:34 AM
Unknown Object (File)
Dec 22 2023, 1:30 AM
Unknown Object (File)
Dec 21 2023, 6:21 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Branch
welcome10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21856
Build 29825: Run Core Tests
Build 29824: arc lint + arc unit