Page MenuHomePhabricator

Allow users to unlink their last external account with a warning, instead of preventing the action
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:20 PM.

Details

Summary

Depends on D20105. Fixes T7732. T7732 describes a case where a user had their Google credentials swapped and had trouble regaining access to their account.

Since we now allow email login even if password auth is disabled, it's okay to let users unlink their final account, and it's even reasonable for users to unlink their final account if it is mis-linked.

Just give them a warning that what they're doing is a little sketchy, rather than preventing the workflow.

Test Plan

Unlinked my only login account, got a stern warning instead of a dead end.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 6 2019, 4:20 PM
epriestley requested review of this revision.Feb 6 2019, 4:22 PM
amckinley accepted this revision.Feb 6 2019, 5:44 PM
This revision is now accepted and ready to land.Feb 6 2019, 5:44 PM
epriestley updated this revision to Diff 48029.Feb 7 2019, 12:54 AM
  • Correct one mistake in a method that's removed a couple of diffs from now anyway.
This revision was automatically updated to reflect the committed changes.