Page MenuHomePhabricator

Allow users to unlink their last external account with a warning, instead of preventing the action
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:20 PM.
Tags
None
Referenced Files
F13317410: D20106.diff
Thu, Jun 13, 9:24 AM
F13314600: D20106.id48014.diff
Tue, Jun 11, 10:21 PM
F13308233: D20106.diff
Mon, Jun 10, 1:45 AM
F13308044: D20106.id.diff
Mon, Jun 10, 12:10 AM
F13304783: D20106.diff
Sat, Jun 8, 12:52 PM
F13259299: D20106.id48014.diff
Sun, May 26, 7:12 PM
F13252443: D20106.diff
Sat, May 25, 1:27 AM
F13240010: D20106.id48030.diff
Wed, May 22, 9:18 AM
Subscribers
None

Details

Summary

Depends on D20105. Fixes T7732. T7732 describes a case where a user had their Google credentials swapped and had trouble regaining access to their account.

Since we now allow email login even if password auth is disabled, it's okay to let users unlink their final account, and it's even reasonable for users to unlink their final account if it is mis-linked.

Just give them a warning that what they're doing is a little sketchy, rather than preventing the workflow.

Test Plan

Unlinked my only login account, got a stern warning instead of a dead end.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable