Differential D20105

In "External Accounts", replace hard-to-find tiny "link" icon with a nice button with text on it
ClosedPublic
Actions

Authored by epriestley on Feb 6 2019, 3:26 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T6703: Allow multiple copies of the same auth provider type

Commits

rPd6f691cf5d5d: In "External Accounts", replace hard-to-find tiny "link" icon with a nice…

Summary

Ref T6703. Replaces the small "link" icon with a more obvious "Link External Account" button.

Moves us toward operating against $config objects instead of against $provider objects, which is more modern and will some day allow us to resolve T6703.

Test Plan

Viewed page, saw a more obvious button. Linked an external account.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 6 2019, 3:26 PM

Harbormaster completed remote builds in B21853: Diff 48013.Feb 6 2019, 3:28 PM

epriestley requested review of this revision.Feb 6 2019, 3:28 PM

epriestley added a child revision: D20106: Allow users to unlink their last external account with a warning, instead of preventing the action.Feb 6 2019, 4:20 PM

amckinley accepted this revision.Feb 6 2019, 5:41 PM

amckinley added inline comments.

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
121–123	"have a linked"

This revision is now accepted and ready to land.Feb 6 2019, 5:41 PM

Typo fix.

Closed by commit rPd6f691cf5d5d: In "External Accounts", replace hard-to-find tiny "link" icon with a nice… (authored by epriestley). · Explain WhyFeb 7 2019, 12:07 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B21864: Diff 48024.Feb 7 2019, 12:07 AM

epriestley mentioned this in T6703: Allow multiple copies of the same auth provider type.Feb 7 2019, 1:40 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

storage/

PhabricatorAuthProviderConfig.php

9 lines

settings/

panel/

PhabricatorExternalAccountsSettingsPanel.php

33 lines

Diff 48025

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php