Page MenuHomePhabricator

In "External Accounts", replace hard-to-find tiny "link" icon with a nice button with text on it
ClosedPublic

Authored by epriestley on Wed, Feb 6, 3:26 PM.

Details

Summary

Ref T6703. Replaces the small "link" icon with a more obvious "Link External Account" button.

Moves us toward operating against $config objects instead of against $provider objects, which is more modern and will some day allow us to resolve T6703.

Test Plan

Viewed page, saw a more obvious button. Linked an external account.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Feb 6, 3:26 PM
epriestley requested review of this revision.Wed, Feb 6, 3:28 PM
amckinley accepted this revision.Wed, Feb 6, 5:41 PM
amckinley added inline comments.
src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
121–123

"have a linked"

This revision is now accepted and ready to land.Wed, Feb 6, 5:41 PM
epriestley updated this revision to Diff 48024.Thu, Feb 7, 12:05 AM
  • Typo fix.
This revision was automatically updated to reflect the committed changes.