Page MenuHomePhabricator
Differential D20105

In "External Accounts", replace hard-to-find tiny "link" icon with a nice button with text on it
ClosedPublic
Actions

Authored by epriestley on Feb 6 2019, 3:26 PM.
Tags
None
Referenced Files
F15544068: D20105.id48024.diff
Sat, Apr 26, 2:42 AM
F15542434: D20105.id.diff
Fri, Apr 25, 4:45 PM
F15541683: D20105.diff
Fri, Apr 25, 1:05 PM
F15538863: D20105.diff
Thu, Apr 24, 9:57 PM
F15522460: D20105.id48024.diff
Sun, Apr 20, 8:12 PM
F15516379: D20105.id48024.diff
Fri, Apr 18, 6:50 PM
F15502503: D20105.id48025.diff
Mon, Apr 14, 1:38 AM
F15466675: D20105.id48013.diff
Thu, Apr 3, 8:11 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T6703: Allow multiple copies of the same auth provider type
Commits
rPd6f691cf5d5d: In "External Accounts", replace hard-to-find tiny "link" icon with a nice…
Summary

Ref T6703. Replaces the small "link" icon with a more obvious "Link External Account" button.

Moves us toward operating against $config objects instead of against $provider objects, which is more modern and will some day allow us to resolve T6703.

Test Plan

Viewed page, saw a more obvious button. Linked an external account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
storage/
9 lines
settings/
panel/
33 lines

Diff 48025

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php

Loading...
Phabricator · Built by Phacility