Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F15398055: D20107.diff
Sun, Mar 16, 11:13 PM
F15390600: D20107.id48016.diff
Sat, Mar 15, 6:21 AM
F15320008: D20107.id48015.diff
Thu, Mar 6, 9:37 PM
Unknown Object (File)
Tue, Feb 25, 5:36 PM
Unknown Object (File)
Tue, Feb 25, 10:47 AM
Unknown Object (File)
Fri, Feb 21, 1:19 AM
Unknown Object (File)
Thu, Feb 20, 3:10 PM
Unknown Object (File)
Thu, Feb 20, 3:32 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable