Page MenuHomePhabricator

Remove weird integration between Legalpad and the ExternalAccount table
ClosedPublic

Authored by epriestley on Feb 6 2019, 6:49 PM.

Details

Summary

Depends on D20107. Ref T6703. Legalpad currently inserts "email" records into the external account table, but they're never used for anything and nothing else references them.

They also aren't necessary for anything important to work, and the only effect they have is making the UI say "External Account" instead of "None" under the "Account" column. In particular, the signatures still record the actual email address.

Stop doing this, remove all the references, and destroy all the rows.

(Long ago, Maniphest may also have done this, but no longer does. Nuance/Gatekeeper use a more modern and more suitable "ExternalObject" thing that I initially started adapting here before realizing that Legalpad doesn't actually care about this data.)

Test Plan

Signed documents with an email address, saw signature reflected properly in UI. Grepped for other callsites.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 6 2019, 6:49 PM
Owners added a subscriber: Restricted Owners Package.Feb 6 2019, 6:49 PM
epriestley requested review of this revision.Feb 6 2019, 6:51 PM

As a general sanity check on DELETE being safe here, we have 59 of these accounts on this install (since July 2014) and all of them appear to be signatures on L28. Many of them, like Test@example.org, are also most likely not authentic.

amckinley accepted this revision.Feb 7 2019, 6:32 PM
This revision is now accepted and ready to land.Feb 7 2019, 6:32 PM
This revision was automatically updated to reflect the committed changes.