Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F19029372: D20107.id.diff
Nov 24 2025, 5:45 PM
F19029370: D20107.diff
Nov 24 2025, 5:44 PM
F18959725: D20107.id.diff
Nov 13 2025, 7:55 AM
F18833136: D20107.id.diff
Oct 26 2025, 12:52 AM
F18814843: D20107.id48031.diff
Oct 21 2025, 12:00 AM
F18814842: D20107.id48016.diff
Oct 21 2025, 12:00 AM
F18814841: D20107.id48015.diff
Oct 21 2025, 12:00 AM
F18814840: D20107.id.diff
Oct 21 2025, 12:00 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable