Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F14084084: D20107.diff
Sat, Nov 23, 6:45 AM
Unknown Object (File)
Mon, Nov 18, 10:45 PM
Unknown Object (File)
Thu, Nov 14, 4:39 PM
Unknown Object (File)
Thu, Nov 14, 3:37 PM
Unknown Object (File)
Mon, Nov 11, 4:07 AM
Unknown Object (File)
Sat, Nov 9, 3:27 PM
Unknown Object (File)
Wed, Nov 6, 9:09 PM
Unknown Object (File)
Oct 24 2024, 7:53 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable