Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F15454670: D20107.id.diff
Sat, Mar 29, 7:41 PM
F15442889: D20107.id48031.diff
Thu, Mar 27, 1:08 AM
F15435642: D20107.id48016.diff
Tue, Mar 25, 9:28 AM
F15432282: D20107.diff
Mon, Mar 24, 5:16 PM
F15427552: D20107.id.diff
Sun, Mar 23, 2:53 PM
F15424793: D20107.id48015.diff
Sun, Mar 23, 12:20 AM
F15421795: D20107.id48016.diff
Sat, Mar 22, 2:16 AM
F15421737: D20107.diff
Sat, Mar 22, 1:58 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable