Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F18264460: D20107.diff
Fri, Aug 22, 10:48 AM
F18201750: D20107.id48031.diff
Mon, Aug 18, 8:31 AM
F18201749: D20107.id.diff
Mon, Aug 18, 8:31 AM
F18201748: D20107.id48015.diff
Mon, Aug 18, 8:31 AM
F18201746: D20107.id48016.diff
Mon, Aug 18, 8:30 AM
F18201319: D20107.diff
Mon, Aug 18, 7:08 AM
F18086875: D20107.id48031.diff
Wed, Aug 6, 12:53 AM
F18086760: D20107.id48031.diff
Tue, Aug 5, 11:55 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable