Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F15549928: D20107.id48016.diff
Sun, Apr 27, 8:18 AM
F15544946: D20107.id.diff
Sat, Apr 26, 8:02 AM
F15543109: D20107.diff
Fri, Apr 25, 8:54 PM
F15542761: D20107.id48016.diff
Fri, Apr 25, 6:43 PM
F15542130: D20107.diff
Fri, Apr 25, 3:55 PM
F15520055: D20107.id48031.diff
Sun, Apr 20, 2:57 AM
F15520053: D20107.id.diff
Sun, Apr 20, 2:56 AM
F15520051: D20107.id48015.diff
Sun, Apr 20, 2:56 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable