Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 15 2026, 7:56 PM
Unknown Object (File)
Apr 8 2026, 3:50 PM
Unknown Object (File)
Mar 30 2026, 12:41 AM
Unknown Object (File)
Mar 28 2026, 3:19 PM
Unknown Object (File)
Mar 9 2026, 1:07 PM
Unknown Object (File)
Mar 7 2026, 9:01 PM
Unknown Object (File)
Feb 14 2026, 6:56 PM
Unknown Object (File)
Feb 3 2026, 7:20 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable