Page MenuHomePhabricator

Make two ancient migrations fatal if they affect data
ClosedPublic

Authored by epriestley on Feb 6 2019, 4:57 PM.
Tags
None
Referenced Files
F19824269: D20107.id48031.diff
Sat, Mar 7, 9:01 PM
F19731111: D20107.id48015.diff
Sat, Feb 14, 6:56 PM
F19603526: D20107.diff
Feb 3 2026, 7:20 AM
F19545795: D20107.id48015.diff
Jan 24 2026, 6:33 PM
F19545638: D20107.id48031.diff
Jan 24 2026, 1:52 PM
F19517180: D20107.id.diff
Jan 15 2026, 8:25 AM
F19516065: D20107.diff
Jan 14 2026, 7:27 PM
F19515801: D20107.diff
Jan 14 2026, 3:55 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20106. Ref T6703. Since I plan to change the ExternalAccount table, these migrations (which rely on save()) will stop working.

They could be rewritten to use raw queries, but I suspect few or no installs are affected. At least for now, just make them safe: if they would affect data, fatal and tell the user to perform a more gradual upgrade.

Also remove an ALTER IGNORE TABLE (this syntax was removed at some point) and fix a %Q when adjusting certain types of primary keys.

Test Plan

Ran bin/storage upgrade --no-quickstart --force --namespace test1234 to get a complete migration since the beginning of time.

Diff Detail

Repository
rP Phabricator
Branch
welcome10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21856
Build 29825: Run Core Tests
Build 29824: arc lint + arc unit