Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 7:40 AM
Unknown Object (File)
Thu, Jan 16, 6:16 PM
Unknown Object (File)
Mon, Dec 30, 8:22 PM
Unknown Object (File)
Wed, Dec 25, 2:00 PM
Unknown Object (File)
Sun, Dec 22, 10:09 AM
Unknown Object (File)
Fri, Dec 20, 11:06 AM
Unknown Object (File)
Fri, Dec 20, 2:51 AM
Unknown Object (File)
Dec 14 2024, 8:01 PM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable