Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
F15470363: D20035.id47844.diff
Fri, Apr 4, 9:40 PM
F15469350: D20035.id.diff
Fri, Apr 4, 12:19 PM
F15467656: D20035.diff
Thu, Apr 3, 5:15 PM
F15436851: D20035.id47844.diff
Tue, Mar 25, 4:40 PM
F15428139: D20035.id47844.diff
Sun, Mar 23, 6:40 PM
F15403074: D20035.id.diff
Tue, Mar 18, 1:49 AM
F15399306: D20035.id47844.diff
Mon, Mar 17, 3:52 AM
Unknown Object (File)
Mar 3 2025, 9:34 PM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable