Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
F17788341: D20035.id47864.diff
Thu, Jul 24, 5:46 PM
F17770854: D20035.id.diff
Wed, Jul 23, 10:22 AM
F17770388: D20035.id.diff
Wed, Jul 23, 9:33 AM
F17750723: D20035.diff
Tue, Jul 22, 4:06 AM
F17750531: D20035.diff
Tue, Jul 22, 3:44 AM
F17661506: D20035.id47844.diff
Sat, Jul 12, 4:27 PM
F17658476: D20035.id.diff
Sat, Jul 12, 1:22 PM
F17645765: D20035.diff
Fri, Jul 11, 11:58 PM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable