Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
F14065363: D20035.diff
Tue, Nov 19, 4:22 AM
F13989716: D20035.id47864.diff
Mon, Oct 21, 10:34 PM
F13974758: D20035.id47844.diff
Oct 18 2024, 7:17 AM
F13974078: D20035.diff
Oct 18 2024, 3:58 AM
F13968917: D20035.diff
Oct 16 2024, 11:26 PM
F13967202: D20035.diff
Oct 16 2024, 12:13 PM
Unknown Object (File)
Oct 11 2024, 11:46 AM
Unknown Object (File)
Oct 9 2024, 11:29 AM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable