Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
F18770681: D20035.id.diff
Oct 8 2025, 2:13 PM
F18628099: D20035.diff
Sep 16 2025, 5:34 AM
F18616496: D20035.diff
Sep 14 2025, 5:49 PM
F18614282: D20035.id.diff
Sep 14 2025, 12:43 PM
F18604254: D20035.diff
Sep 13 2025, 6:21 PM
F18566926: D20035.id.diff
Sep 9 2025, 3:01 PM
F18185408: D20035.id47844.diff
Aug 16 2025, 3:59 PM
F18185181: D20035.id47864.diff
Aug 16 2025, 3:22 PM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable