Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
F19938391: D20035.id47864.diff
Tue, Apr 14, 2:25 AM
F19928440: D20035.diff
Wed, Apr 8, 11:11 AM
F19810860: D20035.diff
Mar 3 2026, 9:18 PM
F19810854: D20035.diff
Mar 3 2026, 9:17 PM
F19562328: D20035.diff
Jan 31 2026, 12:39 PM
F19562327: D20035.diff
Jan 31 2026, 12:39 PM
F19519049: D20035.id47864.diff
Jan 16 2026, 1:17 AM
F19516539: D20035.id47864.diff
Jan 15 2026, 1:13 AM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable