Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 2:05 AM
Unknown Object (File)
Mon, Feb 17, 3:23 PM
Unknown Object (File)
Fri, Feb 14, 11:01 AM
Unknown Object (File)
Thu, Feb 13, 9:00 PM
Unknown Object (File)
Thu, Feb 13, 9:00 PM
Unknown Object (File)
Thu, Feb 13, 2:47 AM
Unknown Object (File)
Sun, Feb 9, 7:01 AM
Unknown Object (File)
Sun, Feb 9, 7:01 AM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable