Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 15, 6:32 PM
Unknown Object (File)
Wed, May 7, 12:35 PM
Unknown Object (File)
Tue, May 6, 7:49 PM
Unknown Object (File)
Tue, May 6, 7:03 PM
Unknown Object (File)
Tue, May 6, 5:39 PM
Unknown Object (File)
Tue, May 6, 5:39 PM
Unknown Object (File)
Apr 29 2025, 10:28 PM
Unknown Object (File)
Apr 20 2025, 3:01 AM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable