Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 4:57 PM
Unknown Object (File)
Sun, Apr 21, 5:41 PM
Unknown Object (File)
Sun, Apr 21, 5:20 PM
Unknown Object (File)
Sat, Apr 20, 7:18 AM
Unknown Object (File)
Fri, Apr 19, 4:45 AM
Unknown Object (File)
Fri, Apr 19, 2:59 AM
Unknown Object (File)
Wed, Apr 17, 5:36 PM
Unknown Object (File)
Mon, Apr 15, 8:07 AM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable