Page MenuHomePhabricator

Get rid of "throwResult()" for control flow in MFA factors
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 5:19 PM
Unknown Object (File)
Wed, Mar 27, 5:19 PM
Unknown Object (File)
Sun, Mar 24, 10:14 PM
Unknown Object (File)
Sat, Mar 23, 12:31 PM
Unknown Object (File)
Sat, Mar 23, 12:31 PM
Unknown Object (File)
Wed, Mar 20, 11:52 PM
Unknown Object (File)
Sun, Mar 17, 5:19 PM
Unknown Object (File)
Wed, Mar 13, 6:40 PM
Subscribers
None

Details

Summary

Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.

Test Plan

grep, went through enroll/gate flows on SMS and Duo.

Diff Detail

Repository
rP Phabricator
Branch
mfa5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21698
Build 29597: Run Core Tests
Build 29596: arc lint + arc unit