Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using instanceof for control flow is a lesser evil than using catch, on the balance.
Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13222: 2018 Week 48-51 Bonus Content
- Commits
- rP29b4fad94173: Get rid of "throwResult()" for control flow in MFA factors
grep, went through enroll/gate flows on SMS and Duo.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mfa5
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21698 Build 29597: Run Core Tests Build 29596: arc lint + arc unit