Page MenuHomePhabricator
Differential D20034

Add more factor details to the Settings factor list
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 5:52 PM.
Tags
None
Referenced Files
F19018042: D20034.id.diff
Sun, Nov 23, 10:05 AM
F19018033: D20034.id.diff
Sun, Nov 23, 10:05 AM
F18925270: D20034.diff
Sun, Nov 9, 6:35 PM
F18839434: D20034.id47862.diff
Mon, Oct 27, 4:20 PM
F18824425: D20034.id47843.diff
Oct 23 2025, 3:35 PM
F18779834: D20034.diff
Oct 11 2025, 3:32 PM
F18702852: D20034.diff
Sep 28 2025, 1:52 AM
F18624393: D20034.diff
Sep 15 2025, 7:53 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPbce44385e1e3: Add more factor details to the Settings factor list
Summary

Depends on D20033. Ref T13222. Flesh this UI out a bit, and provide bit-strength information for TOTP.

Also, stop users from adding multiple SMS factors since this is pointless (they all always text your primary contact number).

Test Plan

Screen Shot 2019-01-25 at 9.46.49 AM.png (252×1 px, 51 KB)

Screen Shot 2019-01-25 at 9.49.53 AM.png (386×610 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 47862

View Options

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorSMSAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...
View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...
Phabricator · Built by Phacility