Page MenuHomePhabricator
Differential D20034

Add more factor details to the Settings factor list
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 5:52 PM.
Tags
None
Referenced Files
F19939680: D20034.id47862.diff
Tue, Apr 14, 5:31 PM
F19939212: D20034.diff
Tue, Apr 14, 10:38 AM
F19829188: D20034.id47843.diff
Mar 10 2026, 2:17 AM
F19601717: D20034.id47843.diff
Feb 3 2026, 5:26 AM
F19018042: D20034.id.diff
Nov 23 2025, 10:05 AM
F19018033: D20034.id.diff
Nov 23 2025, 10:05 AM
F18925270: D20034.diff
Nov 9 2025, 6:35 PM
F18839434: D20034.id47862.diff
Oct 27 2025, 4:20 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPbce44385e1e3: Add more factor details to the Settings factor list
Summary

Depends on D20033. Ref T13222. Flesh this UI out a bit, and provide bit-strength information for TOTP.

Also, stop users from adding multiple SMS factors since this is pointless (they all always text your primary contact number).

Test Plan

Screen Shot 2019-01-25 at 9.46.49 AM.png (252×1 px, 51 KB)

Screen Shot 2019-01-25 at 9.49.53 AM.png (386×610 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 47862

View Options

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorSMSAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...
View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...
Phabricator · Built by Phacility