Page MenuHomePhabricator
Differential D20034

Add more factor details to the Settings factor list
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 5:52 PM.
Tags
None
Referenced Files
F14750939: D20034.id.diff
Tue, Jan 21, 12:02 PM
F14745331: D20034.diff
Tue, Jan 21, 9:23 AM
Unknown Object (File)
Fri, Jan 3, 6:19 AM
Unknown Object (File)
Tue, Dec 31, 9:01 PM
Unknown Object (File)
Sun, Dec 22, 4:03 PM
Unknown Object (File)
Dec 22 2024, 10:04 AM
Unknown Object (File)
Dec 22 2024, 1:55 AM
Unknown Object (File)
Nov 29 2024, 4:30 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPbce44385e1e3: Add more factor details to the Settings factor list
Summary

Depends on D20033. Ref T13222. Flesh this UI out a bit, and provide bit-strength information for TOTP.

Also, stop users from adding multiple SMS factors since this is pointless (they all always text your primary contact number).

Test Plan

Screen Shot 2019-01-25 at 9.46.49 AM.png (252×1 px, 51 KB)

Screen Shot 2019-01-25 at 9.49.53 AM.png (386×610 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 47862

View Options

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorSMSAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...
View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...
Phabricator · Built by Phacility