Page MenuHomePhabricator
Differential D20036

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:19 PM.
Tags
None
Referenced Files
F15582930: D20036.id.diff
Wed, May 7, 6:55 PM
F15578131: D20036.id47865.diff
Tue, May 6, 5:40 PM
F15578129: D20036.id.diff
Tue, May 6, 5:40 PM
F15576601: D20036.diff
Tue, May 6, 9:48 AM
F15525454: D20036.id.diff
Mon, Apr 21, 2:34 PM
F15504342: D20036.diff
Mon, Apr 14, 5:32 PM
F15490623: D20036.id47845.diff
Fri, Apr 11, 7:02 PM
F15483359: D20036.id47865.diff
Wed, Apr 9, 11:56 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA
Summary

Depends on D20035. Ref T13222.

  • Allow individual transactions to request one-shot MFA if available.
  • Make "change username" request MFA.
Test Plan
  • Renamed a user, got prompted for MFA, provided it.
  • Saw that I no longer remain in high-security after performing the edit.
  • Grepped for other uses of PhabricatorUserUsernameTransaction, found none.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
8 lines
xaction/
7 lines
transactions/
editor/
48 lines
storage/
6 lines

Diff 47865

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...
View Options

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility