Page MenuHomePhabricator

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic

Authored by epriestley on Jan 25 2019, 6:19 PM.

Details

Summary

Depends on D20035. Ref T13222.

  • Allow individual transactions to request one-shot MFA if available.
  • Make "change username" request MFA.
Test Plan
  • Renamed a user, got prompted for MFA, provided it.
  • Saw that I no longer remain in high-security after performing the edit.
  • Grepped for other uses of PhabricatorUserUsernameTransaction, found none.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 25 2019, 6:19 PM
epriestley requested review of this revision.Jan 25 2019, 6:21 PM
amckinley accepted this revision.Jan 28 2019, 4:59 PM
This revision is now accepted and ready to land.Jan 28 2019, 4:59 PM
This revision was automatically updated to reflect the committed changes.