Page MenuHomePhabricator
Differential D20036

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Fri, Jan 25, 6:19 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA
Summary

Depends on D20035. Ref T13222.

  • Allow individual transactions to request one-shot MFA if available.
  • Make "change username" request MFA.
Test Plan
  • Renamed a user, got prompted for MFA, provided it.
  • Saw that I no longer remain in high-security after performing the edit.
  • Grepped for other uses of PhabricatorUserUsernameTransaction, found none.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Jan 25, 6:19 PM
epriestley requested review of this revision.Fri, Jan 25, 6:21 PM
amckinley accepted this revision.Mon, Jan 28, 4:59 PM
This revision is now accepted and ready to land.Mon, Jan 28, 4:59 PM
Closed by commit rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA (authored by epriestley). · Explain WhyMon, Jan 28, 5:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47865

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...
View Options

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility