Page MenuHomePhabricator
Differential D20037

Replace "Show Secret" in Passphrase with one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:23 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rP44a0b3e83d90: Replace "Show Secret" in Passphrase with one-shot MFA
Summary

Depends on D20036. Ref T13222. Now that we support one-shot MFA, swap this from session MFA to one-shot MFA.

Test Plan

Revealed a credential, was no longer left in high-security mode.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 25 2019, 6:23 PM
Harbormaster completed remote builds in B21700: Diff 47846.Jan 25 2019, 6:25 PM
epriestley requested review of this revision.Jan 25 2019, 6:25 PM
epriestley mentioned this in T13134: Give Conduit API tokens PHIDs, transactions, and other modern capabilities.Jan 25 2019, 6:26 PM
epriestley added a child revision: D20038: Require MFA to edit MFA providers.Jan 25 2019, 6:45 PM
amckinley accepted this revision.Jan 28 2019, 4:59 PM
This revision is now accepted and ready to land.Jan 28 2019, 5:00 PM
Closed by commit rP44a0b3e83d90: Replace "Show Secret" in Passphrase with one-shot MFA (authored by epriestley). · Explain WhyJan 28 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
controller/
9 lines
storage/
4 lines
xaction/
6 lines

Diff 47866

View Options

src/applications/passphrase/controller/PassphraseCredentialRevealController.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/passphrase/xaction/PassphraseCredentialLookedAtTransaction.php

Loading...
Phabricator · Built by Phacility