Page MenuHomePhabricator
Differential D20038

Require MFA to edit MFA providers
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:45 PM.
Tags
None
Referenced Files
F13230595: D20038.diff
Mon, May 20, 11:05 PM
F13206352: D20038.id.diff
Wed, May 15, 7:30 AM
F13191929: D20038.id47867.diff
Sun, May 12, 2:42 AM
F13185408: D20038.diff
Sat, May 11, 2:53 AM
F13176728: D20038.diff
Wed, May 8, 4:39 PM
F13176223: D20038.diff
Wed, May 8, 11:49 AM
Unknown Object (File)
Tue, May 7, 5:29 AM
Unknown Object (File)
May 3 2024, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI
T13222: 2018 Week 48-51 Bonus Content
Commits
rPd8d4efe89e85: Require MFA to edit MFA providers
Summary

Depends on D20037. Ref T13222. Ref T7667. Although administrators can now disable MFA from the web UI, at least require that they survive MFA gates to do so. T7667 (bin/auth lock) should provide a sturdier approach here in the long term.

Test Plan

Created and edited MFA providers, was prompted for MFA.

Diff Detail

Repository
rP Phabricator
Branch
mfa8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21701
Build 29603: Run Core Tests
Build 29602: arc lint + arc unit

Revision Contents
Changeset List

Diff 47847

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthFactorProviderMFAEngine.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...
Phabricator · Built by Phacility