Page MenuHomePhabricator
Differential D20036

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:19 PM.
Tags
None
Referenced Files
F14053816: D20036.diff
Fri, Nov 15, 7:50 PM
F14042022: D20036.diff
Mon, Nov 11, 11:47 PM
F14025421: D20036.diff
Thu, Nov 7, 5:43 PM
F14017484: D20036.diff
Mon, Nov 4, 5:39 PM
F14011432: D20036.id47865.diff
Fri, Nov 1, 12:32 AM
F14005523: D20036.diff
Sun, Oct 27, 2:43 PM
F13974845: D20036.id47865.diff
Oct 18 2024, 7:38 AM
F13967196: D20036.diff
Oct 16 2024, 12:13 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA
Summary

Depends on D20035. Ref T13222.

  • Allow individual transactions to request one-shot MFA if available.
  • Make "change username" request MFA.
Test Plan
  • Renamed a user, got prompted for MFA, provided it.
  • Saw that I no longer remain in high-security after performing the edit.
  • Grepped for other uses of PhabricatorUserUsernameTransaction, found none.

Diff Detail

Repository
rP Phabricator
Branch
mfa6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21699
Build 29599: Run Core Tests
Build 29598: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
8 lines
xaction/
7 lines
transactions/
editor/
48 lines
storage/
6 lines

Diff 47845

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...
View Options

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility