Page MenuHomePhabricator
Differential D20036

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:19 PM.
Tags
None
Referenced Files
F14918394: D20036.id47865.diff
Thu, Feb 13, 9:00 PM
F14918393: D20036.id.diff
Thu, Feb 13, 9:00 PM
Unknown Object (File)
Sun, Feb 9, 7:01 AM
Unknown Object (File)
Sun, Feb 9, 7:01 AM
Unknown Object (File)
Sun, Feb 9, 7:01 AM
Unknown Object (File)
Tue, Feb 4, 8:27 PM
Unknown Object (File)
Tue, Jan 28, 4:41 AM
Unknown Object (File)
Tue, Jan 28, 4:41 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA
Summary

Depends on D20035. Ref T13222.

  • Allow individual transactions to request one-shot MFA if available.
  • Make "change username" request MFA.
Test Plan
  • Renamed a user, got prompted for MFA, provided it.
  • Saw that I no longer remain in high-security after performing the edit.
  • Grepped for other uses of PhabricatorUserUsernameTransaction, found none.

Diff Detail

Repository
rP Phabricator
Branch
mfa6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21699
Build 29599: Run Core Tests
Build 29598: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
8 lines
xaction/
7 lines
transactions/
editor/
48 lines
storage/
6 lines

Diff 47845

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

Loading...
View Options

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Loading...
Phabricator · Built by Phacility