Paths

Table of Contentst

Differential D20036

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:19 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA

Summary

Depends on D20035. Ref T13222.

Allow individual transactions to request one-shot MFA if available.
Make "change username" request MFA.

Test Plan

Renamed a user, got prompted for MFA, provided it.
Saw that I no longer remain in high-security after performing the edit.
Grepped for other uses of PhabricatorUserUsernameTransaction, found none.

Diff Detail

Repository

rP Phabricator

Branch

mfa6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21699
Build 29599: Run Core Tests
Build 29598: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 25 2019, 6:19 PM

Harbormaster completed remote builds in B21699: Diff 47845.Jan 25 2019, 6:21 PM

epriestley requested review of this revision.Jan 25 2019, 6:21 PM

epriestley added a child revision: D20037: Replace "Show Secret" in Passphrase with one-shot MFA.Jan 25 2019, 6:23 PM

amckinley accepted this revision.Jan 28 2019, 4:59 PM

This revision is now accepted and ready to land.Jan 28 2019, 4:59 PM

Closed by commit rPd24e66724d3b: Convert "Rename User" from session MFA to one-shot MFA (authored by epriestley). · Explain WhyJan 28 2019, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleRenameController.php

8 lines

xaction/

PhabricatorUserUsernameTransaction.php

7 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

48 lines

storage/

PhabricatorModularTransactionType.php

6 lines

Diff 47845

View Options

src/applications/people/controller/PhabricatorPeopleRenameController.php

View Options

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Convert "Rename User" from session MFA to one-shot MFAClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47845

src/applications/people/controller/PhabricatorPeopleRenameController.php

src/applications/people/xaction/PhabricatorUserUsernameTransaction.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Convert "Rename User" from session MFA to one-shot MFA
ClosedPublic
Actions

Revision Contents
Changeset List