Page MenuHomePhabricator

Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 2:45 AM
Unknown Object (File)
Tue, Dec 24, 6:35 PM
Unknown Object (File)
Tue, Dec 24, 12:08 PM
Unknown Object (File)
Fri, Dec 20, 5:17 PM
Unknown Object (File)
Wed, Dec 18, 9:32 PM
Unknown Object (File)
Wed, Dec 4, 5:42 PM
Unknown Object (File)
Mon, Dec 2, 11:05 AM
Unknown Object (File)
Nov 18 2024, 8:47 PM
Subscribers
None

Details

Summary

Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of willApplyTransactions().

It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content.

This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.)

Test Plan
  • Created and edited a paste.
  • Grepped for willApplyTransactions().

Note that EditEngine (vs ApplicationTransacitonEditor) still has a willApplyTransactions(), which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works.

Diff Detail

Repository
rP Phabricator
Branch
mfa26
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21378
Build 29107: Run Core Tests
Build 29106: arc lint + arc unit