Page MenuHomePhabricator

Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:34 PM.
Tags
None
Referenced Files
F15393884: D19909.diff
Sat, Mar 15, 11:12 PM
F15385642: D19909.diff
Fri, Mar 14, 11:02 PM
F15360798: D19909.diff
Tue, Mar 11, 10:17 AM
Unknown Object (File)
Mon, Feb 24, 2:26 AM
Unknown Object (File)
Feb 9 2025, 6:49 AM
Unknown Object (File)
Feb 9 2025, 6:49 AM
Unknown Object (File)
Feb 9 2025, 6:49 AM
Unknown Object (File)
Feb 8 2025, 8:13 AM
Subscribers
None

Details

Summary

Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of willApplyTransactions().

It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content.

This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.)

Test Plan
  • Created and edited a paste.
  • Grepped for willApplyTransactions().

Note that EditEngine (vs ApplicationTransacitonEditor) still has a willApplyTransactions(), which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works.

Diff Detail

Repository
rP Phabricator
Branch
mfa26
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21378
Build 29107: Run Core Tests
Build 29106: arc lint + arc unit