Page MenuHomePhabricator

Allow "bin/auth recover" to generate a link which forces a full login session
ClosedPublic

Authored by epriestley on Dec 18 2018, 7:17 PM.
Tags
None
Referenced Files
F15459086: D19903.id47514.diff
Mon, Mar 31, 9:43 AM
F15445672: D19903.diff
Thu, Mar 27, 3:23 PM
F15440663: D19903.id47514.diff
Wed, Mar 26, 2:01 PM
F15440662: D19903.id47591.diff
Wed, Mar 26, 2:00 PM
F15433762: D19903.id47591.diff
Tue, Mar 25, 12:34 AM
F15421671: D19903.diff
Sat, Mar 22, 1:34 AM
F15384789: D19903.id47514.diff
Fri, Mar 14, 8:50 PM
F15369168: D19903.id.diff
Wed, Mar 12, 5:37 AM
Subscribers
None

Details

Summary

Depends on D19902. Ref T13222. This is mostly a "while I'm in here..." change since MFA is getting touched so much anyway.

Doing cluster support, I sometimes need to log into user accounts on instances that have MFA. I currently accomplish this by doing bin/auth recover, getting a parital session, and then forcing it into a full session in the database. This is inconvenient and somewhat dangerous.

Instead, allow bin/auth recover to generate a link that skips the "partial session" stage: adding required MFA, providing MFA, and signing legalpad documents.

Anyone who can run bin/auth recover can do this anyway, this just reduces the chance I accidentally bypass MFA on the wrong session when doing support stuff.

Test Plan
  • Logged in with bin/auth recover, was prompted for MFA.
  • Logged in with bin/auth recover --force-full-session, was not prompted for MFA.
  • Did a password reset, followed reset link, was prompted for MFA.

Diff Detail

Repository
rP Phabricator
Branch
mfa21
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21368
Build 29089: Run Core Tests
Build 29088: arc lint + arc unit