Differential D19896

In Legalpad, prompt for MFA at the end of the workflow instead of the beginning
ClosedPublic
Actions

Authored by epriestley on Dec 17 2018, 7:23 PM.

Tags

None

Referenced Files

	F15501146: D19896.id47504.diff
	Sun, Apr 13, 8:53 PM

	F15498304: D19896.id47557.diff
	Sun, Apr 13, 12:36 PM

	F15495044: D19896.id47505.diff
	Sun, Apr 13, 2:24 AM

	F15492402: D19896.id.diff
	Sat, Apr 12, 2:06 PM

	F15491051: D19896.id.diff
	Fri, Apr 11, 10:55 PM

	F15490936: D19896.diff
	Fri, Apr 11, 9:49 PM

	F15480494: D19896.id47557.diff
	Tue, Apr 8, 2:28 PM

	F15456496: D19896.id47504.diff
	Sun, Mar 30, 10:11 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rP961fd7e8491e: In Legalpad, prompt for MFA at the end of the workflow instead of the beginning

Summary

Depends on D19895. Ref T13222. This is a simple behavioral improvement for the current MFA implementation in Legalpad: don't MFA the user and then realize that they forgot to actually check the box.

Test Plan

Submitted form without the box checked, got an error saying "check the box" instead of MFA.
Submitted the form with the box checked, got an MFA prompt.
Passed the MFA gate, got a signed form.
Tried to sign another form, hit MFA timed lockout.

Diff Detail

Repository

Branch

mfa14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21358
Build 29070: Run Core Tests
Build 29069: arc lint + arc unit

Event Timeline

Actual change which does what I claim.

Harbormaster completed remote builds in B21358: Diff 47504.Dec 17 2018, 7:26 PM

Harbormaster completed remote builds in B21359: Diff 47505.

epriestley requested review of this revision.Dec 17 2018, 7:26 PM

epriestley added a child revision: D19897: Allow any transaction group to be signed with a one-shot "Sign With MFA" action.Dec 17 2018, 8:37 PM

amckinley accepted this revision.Dec 18 2018, 8:50 PM

This revision is now accepted and ready to land.Dec 18 2018, 8:50 PM

Closed by commit rP961fd7e8491e: In Legalpad, prompt for MFA at the end of the workflow instead of the beginning (authored by epriestley). · Explain WhyDec 20 2018, 10:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

controller/

LegalpadDocumentSignController.php

29 lines

Diff 47504

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...